Skip to content

Commit 152589f

Browse files
authored
refactor: change value of meta-service key DatabaseNameIdent from DatabaseId to Id<DatabaseId> (#16299)
* refactor: make Id more generic so that it can include any kind of Id type This will be useful to make `Id<T>` a wrapper type for T to impl `prost::Message` for T. * refactor: change value of meta-service key `DatabaseNameIdent` from `DatabaseId` to `Id<DatabaseId>` `Id<DatabaseId>` is a `prost::Message` and can be used directly as a meta-service value thus it unifies get operation to meta-service. For example, `KVPbApi::get_db()` now can be used to get a u64 id value, instead of using `get_u64_value()`.
1 parent f01852d commit 152589f

File tree

18 files changed

+433
-234
lines changed

18 files changed

+433
-234
lines changed

Cargo.lock

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/meta/api/src/background_api_impl.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ impl<KV: kvapi::KVApi<Error = MetaError>> BackgroundApi for KV {
222222

223223
let job_id = deserialize_u64(&v.data)?;
224224

225-
let req = BackgroundJobIdIdent::new(&req.tenant, job_id.0);
225+
let req = BackgroundJobIdIdent::new(&req.tenant, *job_id);
226226
let seq_info = self.get_pb(&req).await?;
227227

228228
// filter none and get the task info

src/meta/api/src/schema_api_impl.rs

Lines changed: 74 additions & 63 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)