Skip to content

Commit 098224e

Browse files
committed
Remove ClusterHelper in planner
Signed-off-by: Xuanwo <github@xuanwo.io>
1 parent f9f483d commit 098224e

File tree

6 files changed

+14
-5
lines changed

6 files changed

+14
-5
lines changed

src/query/catalog/src/cluster_info.rs

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,3 +20,17 @@ pub struct Cluster {
2020
pub local_id: String,
2121
pub nodes: Vec<Arc<NodeInfo>>,
2222
}
23+
24+
impl Cluster {
25+
/// If this cluster is empty?
26+
///
27+
/// # TODO
28+
///
29+
/// From @Xuanwo
30+
///
31+
/// Ideally, we should implement a cluster trait to replace `ClusterHelper`
32+
/// defined in `databend-query`.
33+
pub fn is_empty(&self) -> bool {
34+
self.nodes.is_empty()
35+
}
36+
}

src/query/service/src/interpreters/interpreter_select.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ use common_exception::Result;
1919
use common_legacy_planners::PlanNode;
2020
use common_legacy_planners::SelectPlan;
2121

22-
use crate::clusters::ClusterHelper;
2322
use crate::interpreters::plan_schedulers;
2423
use crate::interpreters::Interpreter;
2524
use crate::optimizers::Optimizers;

src/query/service/src/interpreters/interpreter_select_v2.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ use common_datavalues::DataSchemaRef;
1818
use common_exception::Result;
1919

2020
use super::plan_schedulers::schedule_query_v2;
21-
use crate::clusters::ClusterHelper;
2221
use crate::interpreters::Interpreter;
2322
use crate::pipelines::PipelineBuildResult;
2423
use crate::sessions::QueryContext;

src/query/service/src/optimizers/optimizer_scatters.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ use common_legacy_planners::StagePlan;
3434
use common_legacy_planners::WindowFuncPlan;
3535
use enum_extract::let_extract;
3636

37-
use crate::clusters::ClusterHelper;
3837
use crate::optimizers::Optimizer;
3938
use crate::sessions::QueryContext;
4039
use crate::sessions::TableContext;

src/query/service/src/sql/planner/binder/insert.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ use common_datavalues::DataSchemaRefExt;
2121
use common_exception::Result;
2222
use tracing::debug;
2323

24-
use crate::clusters::ClusterHelper;
2524
use crate::sql::binder::Binder;
2625
use crate::sql::normalize_identifier;
2726
use crate::sql::optimizer::optimize;

src/query/service/src/sql/planner/mod.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ use common_exception::Result;
2323
use parking_lot::RwLock;
2424
pub use plans::ScalarExpr;
2525

26-
use crate::clusters::ClusterHelper;
2726
use crate::sql::optimizer::optimize;
2827
pub use crate::sql::planner::binder::BindContext;
2928

0 commit comments

Comments
 (0)