chore(query): make user setting depend on a lightweight UserSettingValue instead of DataValue

Author: sundy-li

src/query/datavalues/tests/it/types/viewer.rs

@@ -70,10 +70,9 @@ fn test_constant_viewer() -> Result<()> {
 }
 
 #[test]
- fn test_json() {
-
+fn test_json() {
     let value = DataValue::Int64(53);
     let ss = serde_json::to_vec(&value).unwrap();
     println!("{:?}", ss);
-    println!("{:?}", unsafe { std::str::from_utf8_unchecked(&ss) } );
+    println!("{:?}", unsafe { std::str::from_utf8_unchecked(&ss) });
 }

src/query/management/tests/it/setting.rs

@@ -69,7 +69,10 @@ async fn test_set_setting() -> Result<()> {
 
     // Get settings.
     {
-        let expect = vec![UserSetting::create("max_threads", UserSettingValue::UInt64(1))];
+        let expect = vec![UserSetting::create(
+            "max_threads",
+            UserSettingValue::UInt64(1),
+        )];
         let actual = mgr.get_settings().await?;
         assert_eq!(actual, expect);
     }

src/query/settings/src/lib.rs

@@ -577,7 +577,9 @@ impl Settings {
         Ok(())
     }
 
-    pub fn get_setting_values(&self) -> Vec<(String, UserSettingValue, UserSettingValue, String, String)> {
+    pub fn get_setting_values(
+        &self,
+    ) -> Vec<(String, UserSettingValue, UserSettingValue, String, String)> {
         let settings = self.settings.read();
 
         let mut result = vec![];
@@ -625,11 +627,11 @@ impl Settings {
         let mut settings = self.settings.write();
         let values = changed_settings.get_setting_values();
         for value in values.into_iter() {
-                let key = value.0;
-                let mut val = settings.get_mut(&key).ok_or_else(|| {
-                    ErrorCode::UnknownVariable(format!("Unknown variable: {:?}", key))
-                })?;
-                val.user_setting.value = value.1.clone();
+            let key = value.0;
+            let mut val = settings.get_mut(&key).ok_or_else(|| {
+                ErrorCode::UnknownVariable(format!("Unknown variable: {:?}", key))
+            })?;
+            val.user_setting.value = value.1.clone();
         }
         Ok(())
     }

src/query/storages/preludes/src/system/settings_table.rs

@@ -62,7 +62,7 @@ impl SyncSystemTable for SettingsTable {
             let typename = match vals.2 {
                 common_meta_types::UserSettingValue::UInt64(_) => "UInt64",
                 common_meta_types::UserSettingValue::String(_) => "String",
-                _ => unreachable!()
+                _ => unreachable!(),
             };
             // Types.
             types.push(typename.to_string());