fix(query): ignore ascii case for flight compression setting (#13957)

* fix(query): ignore ascii case for flight compression setting

* fix(query): ignore ascii case for flight compression setting

* fix(query): ignore ascii case for flight compression setting

* fix(query): ignore ascii case for flight compression setting

Author: zhang2014

src/query/settings/src/settings_default.rs

@@ -610,14 +610,23 @@ impl DefaultSettings {
         Ok(Self::instance()?.settings.contains_key(key))
     }
 
-    pub fn convert_value(k: String, v: String) -> Result<(String, Option<UserSettingValue>)> {
+    pub fn convert_value(k: String, mut v: String) -> Result<(String, Option<UserSettingValue>)> {
         let default_settings = DefaultSettings::instance()?;
 
         match default_settings.settings.get(&k) {
             None => Ok((k, None)),
             Some(setting_value) => {
                 if let Some(possible_values) = &setting_value.possible_values {
-                    if !possible_values.iter().any(|x| x.eq_ignore_ascii_case(&v)) {
+                    let mut checked_value = false;
+
+                    for possible_value in possible_values {
+                        if possible_value.eq_ignore_ascii_case(&v) {
+                            checked_value = true;
+                            v = possible_value.to_string();
+                        }
+                    }
+
+                    if !checked_value {
                         return Err(ErrorCode::WrongValueForVariable(format!(
                             "Invalid setting value: {:?} for variable {:?}, possible values: {:?}",
                             v, k, possible_values

src/query/settings/src/settings_getter_setter.rs

@@ -258,7 +258,7 @@ impl Settings {
     }
 
     pub fn get_sql_dialect(&self) -> Result<Dialect> {
-        match self.try_get_string("sql_dialect")?.as_str() {
+        match self.try_get_string("sql_dialect")?.to_lowercase().as_str() {
             "hive" => Ok(Dialect::Hive),
             "mysql" => Ok(Dialect::MySQL),
             "experimental" => Ok(Dialect::Experimental),
@@ -267,7 +267,7 @@ impl Settings {
     }
 
     pub fn get_collation(&self) -> Result<&str> {
-        match self.try_get_string("collation")?.as_str() {
+        match self.try_get_string("collation")?.to_lowercase().as_str() {
             "utf8" => Ok("utf8"),
             _ => Ok("binary"),
         }
@@ -503,8 +503,12 @@ impl Settings {
     }
 
     pub fn get_query_flight_compression(&self) -> Result<Option<FlightCompression>> {
-        match self.try_get_string("query_flight_compression")?.as_str() {
-            "None" => Ok(None),
+        match self
+            .try_get_string("query_flight_compression")?
+            .to_uppercase()
+            .as_str()
+        {
+            "NONE" => Ok(None),
             "LZ4" => Ok(Some(FlightCompression::Lz4)),
             "ZSTD" => Ok(Some(FlightCompression::Zstd)),
             _ => unreachable!("check possible_values in set variable"),

tests/sqllogictests/suites/base/06_show/06_0003_show_settings.test

@@ -79,3 +79,19 @@ unset max_memory_usage
 
 statement ok
 unset max_threads
+
+statement ok
+set query_flight_compression = 'Lz4';
+
+query TT
+select value from system.settings where name = 'query_flight_compression'
+----
+LZ4
+
+statement ok
+set query_flight_compression = 'lz4';
+
+query TT
+select value from system.settings where name = 'query_flight_compression'
+----
+LZ4