fix: changed readmi

Author: dmytro_velychko3

README.md

@@ -83,8 +83,8 @@ No modules.
 | <a name="input_metastore_grants"></a> [metastore\_grants](#input\_metastore\_grants)                                      | Permissions to give on metastore to group                                                                                                                                      | `map(list(string))`                                                                                                                                                                                                                                                                                                                                                                               | {}                                                                                                                                                                                                                                                                      |    no    |
 | <a name="input_secret_scope_object"></a> [secret\_scope\_object](#input\_secret\_scope\_object)                           | List of objects, where 'scope_name' param is a Secret scope name and 'acl' are list of objects with 'principals' and one of allowed 'permission' ('READ', 'WRITE' or 'MANAGE') | <pre>list(object({<br> scope_name = string<br> acl = list(object({<br>   principal  = string<br>   permission = string<br>   }))<br>}))</pre>                                                                                                                                                                                                                                                     | <pre>[{<br>  scope_name = null<br>  acl        = null<br>}]</pre>                                                                                                                                                                                                       |    no    |
 | <a name="input_unity_cluster_enabled"></a> [unity\_cluster\_enabled](#input\_unity\_cluster\_enabled)  | Boolean flag for creating databricks claster   | `bool` | false | no |
-| <a name="input_unity_cluster_config"></a> [unity\_unity\_cluster\_config](#input\_unity\_cluster\_config)  | Specifies the databricks unity cluster configuration   |  <pre>object({ <br>   cluster_name            = optional(string)<br>   spark_version           = optional(string)<br>   spark_conf              = optional(map(any))<br>   spark_env_vars          = optional(map(any))<br>   data_security_mode      = optional(string)<br>   node_type_id            = optional(string)<br>   autotermination_minutes = optional(number)<br>   min_workers             = optional(number)<br>   max_workers             = optional(number)<br>   availability            = optional(string)<br>   first_on_demand         = optional(number)<br>   spot_bid_max_price      = optional(number)<br>   permissions = optional(set(object({<br>     group_name       = string<br>     permission_level = string<br>   })))<br>})<br></pre> |  <pre>object({ <br>   cluster_name            = optional("Unity Catalog")<br>   spark_version           = optional("11.3.x-scala2.12")<br>   spark_conf              = optional({})<br>   spark_env_vars          = optional({})<br>   data_security_mode      = optional("USER_ISOLATION")<br>   node_type_id            = optional("Standard_D3_v2")<br>   autotermination_minutes = optional(30)<br>   min_workers             = optional(1)<br>   max_workers             = optional(2)<br>   availability            = optional("ON_DEMAND_AZURE")<br>   first_on_demand         = optional(0)<br>   spot_bid_max_price      = optional(1)<br>   permissions = optional(set(object({<br>     group_name       = string<br>     permission_level = string<br>   })),null)<br>})<br></pre> |   no    |
-| <a name="input_cluster_log_conf_destination"></a> [cluster\_log\_conf\_destination](#input\_cluster\_log\_conf\_destination)  | Provide a dbfs location, example 'dbfs:/cluster-logs', to push all cluster logs to certain location | `string` | " " | no |
+| <a name="input_unity_cluster_config"></a> [unity\_unity\_cluster\_config](#input\_unity\_cluster\_config)  | Specifies the databricks unity cluster configuration   |  <pre>object({ <br>   cluster_name                 = optional(string)<br>   spark_version                = optional(string)<br>   spark_conf                   = optional(map(any))<br>   spark_env_vars               = optional(map(any))<br>   data_security_mode           = optional(string)<br>   node_type_id                 = optional(string)<br>   autotermination_minutes      = optional(number)<br>   min_workers                  = optional(number)<br>   max_workers                  = optional(number)<br>   availability                 = optional(string)<br>   first_on_demand              = optional(number)<br>   spot_bid_max_price           = optional(number)<br>   cluster_log_conf_destination = optional(string, null)<br>   permissions = optional(set(object({<br>     group_name       = string<br>     permission_level = string<br>   })))<br>})<br></pre> |  <pre>object({ <br>   cluster_name                 = optional("Unity Catalog")<br>   spark_version                = optional("11.3.x-scala2.12")<br>   spark_conf                   = optional({})<br>   spark_env_vars               = optional({})<br>   data_security_mode           = optional("USER_ISOLATION")<br>   node_type_id                 = optional("Standard_D3_v2")<br>   autotermination_minutes      = optional(30)<br>   min_workers                  = optional(1)<br>   max_workers                  = optional(2)<br>   availability                 = optional("ON_DEMAND_AZURE")<br>   first_on_demand              = optional(0)<br>   spot_bid_max_price           = optional(1)<br>   cluster_log_conf_destination = optional(string, null)<br>   permissions = optional(set(object({<br>     group_name       = string<br>     permission_level = string<br>   })),null)<br>})<br></pre> |   no    |
+
 
 
 

unity.tf

@@ -157,7 +157,7 @@ resource "databricks_cluster" "this" {
   }
 
   dynamic "cluster_log_conf" {
-    for_each = length(var.cluster_log_conf_destination) == 0 ? [] : [var.cluster_log_conf_destination]
+    for_each = var.unity_cluster_config.cluster_log_conf_destination != null ? [var.unity_cluster_config.cluster_log_conf_destination] : []
     content {
       dbfs {
         destination = cluster_log_conf.value

variables.tf

@@ -195,18 +195,19 @@ variable "unity_cluster_enabled" {
 
 variable "unity_cluster_config" {
   type = object({
-    cluster_name            = optional(string, "Unity Catalog")
-    spark_version           = optional(string, "11.3.x-scala2.12")
-    spark_conf              = optional(map(any), null)
-    spark_env_vars          = optional(map(any), null)
-    data_security_mode      = optional(string, "USER_ISOLATION")
-    node_type_id            = optional(string, "Standard_D3_v2")
-    autotermination_minutes = optional(number, 30)
-    min_workers             = optional(number, 1)
-    max_workers             = optional(number, 2)
-    availability            = optional(string, "ON_DEMAND_AZURE")
-    first_on_demand         = optional(number, 0)
-    spot_bid_max_price      = optional(number, 1)
+    cluster_name                 = optional(string, "Unity Catalog")
+    spark_version                = optional(string, "11.3.x-scala2.12")
+    spark_conf                   = optional(map(any), null)
+    spark_env_vars               = optional(map(any), null)
+    data_security_mode           = optional(string, "USER_ISOLATION")
+    node_type_id                 = optional(string, "Standard_D3_v2")
+    autotermination_minutes      = optional(number, 30)
+    min_workers                  = optional(number, 1)
+    max_workers                  = optional(number, 2)
+    availability                 = optional(string, "ON_DEMAND_AZURE")
+    first_on_demand              = optional(number, 0)
+    spot_bid_max_price           = optional(number, 1)
+    cluster_log_conf_destination = optional(string, null)
     permissions = optional(set(object({
       group_name       = string
       permission_level = string
@@ -215,13 +216,3 @@ variable "unity_cluster_config" {
   description = "Specifies the databricks unity cluster configuration"
   default     = {}
 }
-
-variable "cluster_log_conf_destination" {
-  type        = string
-  description = "Provide a dbfs location to push all cluster logs to certain location"
-  default     = ""
-  validation {
-    condition     = length(var.cluster_log_conf_destination) == 0 ? true : startswith(var.cluster_log_conf_destination, "dbfs:/")
-    error_message = "Provide valid path to dbfs logs folder, example: 'dbfs:/logs'"
-  }
-}