Skip to content

Commit 809b863

Browse files
authored
Merge pull request #13 from data-platform-hq/fix/remove-deprecated-parameters
fix: remove deprecated parameters
2 parents 1a98ee2 + e486963 commit 809b863

File tree

4 files changed

+20
-12
lines changed

4 files changed

+20
-12
lines changed

README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@ Terraform module for creation Azure Network Subnet
99
| Name | Version |
1010
|------|---------|
1111
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.0.0 |
12-
| <a name="requirement_azurerm"></a> [azurerm](#requirement\_azurerm) | >= 3.40.0 |
12+
| <a name="requirement_azurerm"></a> [azurerm](#requirement\_azurerm) | >= 3.104.2 |
1313

1414
## Providers
1515

1616
| Name | Version |
1717
|------|---------|
18-
| <a name="provider_azurerm"></a> [azurerm](#provider\_azurerm) | >= 3.40.0 |
18+
| <a name="provider_azurerm"></a> [azurerm](#provider\_azurerm) | >= 3.104.2 |
1919

2020
## Modules
2121

@@ -43,7 +43,8 @@ No modules.
4343
| <a name="input_network"></a> [network](#input\_network) | The name of the virtual network in which the subnet is created in | `string` | n/a | yes |
4444
| <a name="input_nsg_association_enabled"></a> [nsg\_association\_enabled](#input\_nsg\_association\_enabled) | Boolean flag that determines if NSG association would be created | `bool` | `false` | no |
4545
| <a name="input_nsg_id"></a> [nsg\_id](#input\_nsg\_id) | The ID of the Network Security Group which should be associated with the Subnet | `string` | `null` | no |
46-
| <a name="input_private_endpoint_network_policies_enabled"></a> [private\_endpoint\_network\_policies\_enabled](#input\_private\_endpoint\_network\_policies\_enabled) | Enable or Disable network policies for the private link endpoint on the subnet. Setting this to true will Disable the policy and setting this to false will Enable the policy: [true\|false] | `bool` | `true` | no |
46+
| <a name="input_private_endpoint_network_policies"></a> [private\_endpoint\_network\_policies](#input\_private\_endpoint\_network\_policies) | Enable or Disable network policies for the private endpoint on the subnet. Possible values: [Disabled\|Enabled\|NetworkSecurityGroupEnabled\|RouteTableEnabled] | `string` | `"Enabled"` | no |
47+
| <a name="input_private_link_service_network_policies_enabled"></a> [private\_link\_service\_network\_policies\_enabled](#input\_private\_link\_service\_network\_policies\_enabled) | Enable or Disable network policies for the private link service on the subnet. Setting this to true will Enable the policy and setting this to false will Disable the policy: [true\|false] | `bool` | `true` | no |
4748
| <a name="input_resource_group"></a> [resource\_group](#input\_resource\_group) | The name of the resource group in which to create the storage account | `string` | n/a | yes |
4849
| <a name="input_route_table_association_enabled"></a> [route\_table\_association\_enabled](#input\_route\_table\_association\_enabled) | Boolean flag that determines if Route Table association would be created | `bool` | `false` | no |
4950
| <a name="input_route_table_id"></a> [route\_table\_id](#input\_route\_table\_id) | ID of the Route Table which would be assigned to subnet | `string` | `null` | no |

main.tf

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
resource "azurerm_subnet" "this" {
22
count = var.export_subnet_id == null ? 1 : 0
33

4-
name = var.name
5-
resource_group_name = var.resource_group
6-
virtual_network_name = var.network
7-
private_endpoint_network_policies_enabled = var.private_endpoint_network_policies_enabled
8-
service_endpoints = var.service_endpoints
9-
address_prefixes = [var.cidr]
4+
name = var.name
5+
resource_group_name = var.resource_group
6+
virtual_network_name = var.network
7+
private_endpoint_network_policies = var.private_endpoint_network_policies
8+
private_link_service_network_policies_enabled = var.private_link_service_network_policies_enabled
9+
service_endpoints = var.service_endpoints
10+
address_prefixes = [var.cidr]
1011

1112
dynamic "delegation" {
1213
for_each = var.delegations

variables.tf

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,15 @@ variable "cidr" {
1818
description = "The address prefixes to use for the subnet"
1919
}
2020

21-
variable "private_endpoint_network_policies_enabled" {
21+
variable "private_endpoint_network_policies" {
22+
type = string
23+
description = "Enable or Disable network policies for the private endpoint on the subnet. Possible values: [Disabled|Enabled|NetworkSecurityGroupEnabled|RouteTableEnabled]"
24+
default = "Enabled"
25+
}
26+
27+
variable "private_link_service_network_policies_enabled" {
2228
type = bool
23-
description = "Enable or Disable network policies for the private link endpoint on the subnet. Setting this to true will Disable the policy and setting this to false will Enable the policy: [true|false]"
29+
description = "Enable or Disable network policies for the private link service on the subnet. Setting this to true will Enable the policy and setting this to false will Disable the policy: [true|false]"
2430
default = true
2531
}
2632

versions.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ terraform {
44
required_providers {
55
azurerm = {
66
source = "hashicorp/azurerm"
7-
version = ">= 3.40.0"
7+
version = ">= 3.104.2"
88
}
99
}
1010
}

0 commit comments

Comments
 (0)