Skip to content

IDataFrame.inflateSeries has incorrect type #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yushiyangk opened this issue Apr 29, 2025 · 1 comment
Open

IDataFrame.inflateSeries has incorrect type #181

yushiyangk opened this issue Apr 29, 2025 · 1 comment

Comments

@yushiyangk
Copy link

Using data-forge 1.10.3, IDataFrame.inflateSeries has type defined as follows:

inflateSeries<NewValueT = ValueT>(columnName: string, selector?: SelectorWithIndexFn<IndexT, any>): IDataFrame<IndexT, ValueT>

I believe this is wrong, as the selector argument is a function that takes each value in the series as its arugment; it should not be the IndexT.

@ashleydavis
Copy link
Member

Please feel free to make it look the way you want submit a PR. I'll run the tests and see if it looks ok. If everything checks out we can publish a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants