TST: remove sparse isdtype xfails

Author: lucascolley

tests/test_funcs.py

@@ -404,7 +404,6 @@ def test_none(self, args: tuple[tuple[float | None, ...], ...]):
         assert actual == expect
 
 
-@pytest.mark.xfail_xp_backend(Backend.SPARSE, reason="no isdtype")
 class TestCov:
     def test_basic(self, xp: ModuleType):
         xp_assert_close(
@@ -697,7 +696,6 @@ def test_xp(self, xp: ModuleType):
 @pytest.mark.filterwarnings(  # array_api_strictest
     "ignore:invalid value encountered:RuntimeWarning:array_api_strict"
 )
-@pytest.mark.xfail_xp_backend(Backend.SPARSE, reason="no isdtype")
 class TestIsClose:
     @pytest.mark.parametrize("swap", [False, True])
     @pytest.mark.parametrize(
@@ -919,7 +917,6 @@ def test_kron_shape(
         k = kron(a, b)
         assert k.shape == expected_shape
 
-    @pytest.mark.xfail_xp_backend(Backend.SPARSE, reason="no isdtype")
     def test_python_scalar(self, xp: ModuleType):
         a = 1
         # Test no dtype promotion to xp.asarray(a); use b.dtype
@@ -1138,7 +1135,6 @@ def test_xp(self, xp: ModuleType):
         xp_assert_equal(actual, expected)
 
 
-@pytest.mark.xfail_xp_backend(Backend.SPARSE, reason="no isdtype")
 class TestSinc:
     def test_simple(self, xp: ModuleType):
         xp_assert_equal(sinc(xp.asarray(0.0)), xp.asarray(1.0))

tests/test_helpers.py

@@ -79,7 +79,6 @@ def test_xp(self, xp: ModuleType):
 
 
 class TestAsArrays:
-    @pytest.mark.xfail_xp_backend(Backend.SPARSE, reason="no isdtype")
     @pytest.mark.parametrize(
         ("dtype", "b", "defined"),
         [

tests/test_testing.py

@@ -38,12 +38,7 @@ def test_device(self, xp: ModuleType, device: Device):
 
 
 class TestAssertEqualCloseLess:
-    pr_assert_close = pytest.param(  # pyright: ignore[reportUnannotatedClassAttribute]
-        xp_assert_close,
-        marks=pytest.mark.xfail_xp_backend(Backend.SPARSE, reason="no isdtype"),
-    )
-
-    @pytest.mark.parametrize("func", [xp_assert_equal, pr_assert_close])
+    @pytest.mark.parametrize("func", [xp_assert_equal, xp_assert_close])
     def test_assert_equal_close_basic(self, xp: ModuleType, func: Callable[..., None]):
         func(xp.asarray(0), xp.asarray(0))
         func(xp.asarray([1, 2]), xp.asarray([1, 2]))
@@ -75,7 +70,7 @@ def test_namespace(self, xp: ModuleType, func: Callable[..., None]):
         with pytest.raises(TypeError, match="list is not a supported array type"):
             func(xp.asarray([0]), [0])
 
-    @pytest.mark.parametrize("func", [xp_assert_equal, pr_assert_close, xp_assert_less])
+    @pytest.mark.parametrize("func", [xp_assert_equal, xp_assert_close, xp_assert_less])
     def test_check_shape(self, xp: ModuleType, func: Callable[..., None]):
         a = xp.asarray([1] if func is xp_assert_less else [2])
         b = xp.asarray(2)
@@ -90,7 +85,7 @@ def test_check_shape(self, xp: ModuleType, func: Callable[..., None]):
         with pytest.raises(AssertionError, match="sizes do not match"):
             func(a, d, check_shape=False)
 
-    @pytest.mark.parametrize("func", [xp_assert_equal, pr_assert_close, xp_assert_less])
+    @pytest.mark.parametrize("func", [xp_assert_equal, xp_assert_close, xp_assert_less])
     def test_check_dtype(self, xp: ModuleType, func: Callable[..., None]):
         a = xp.asarray(1 if func is xp_assert_less else 2)
         b = xp.asarray(2, dtype=xp.int16)
@@ -102,7 +97,7 @@ def test_check_dtype(self, xp: ModuleType, func: Callable[..., None]):
         with pytest.raises(AssertionError, match="Mismatched elements"):
             func(a, c, check_dtype=False)
 
-    @pytest.mark.parametrize("func", [xp_assert_equal, pr_assert_close, xp_assert_less])
+    @pytest.mark.parametrize("func", [xp_assert_equal, xp_assert_close, xp_assert_less])
     @pytest.mark.xfail_xp_backend(
         Backend.SPARSE, reason="sparse [()] returns np.generic"
     )
@@ -122,7 +117,6 @@ def test_check_scalar(
         with pytest.raises(AssertionError, match="Mismatched elements"):
             func(a, c, check_scalar=True)
 
-    @pytest.mark.xfail_xp_backend(Backend.SPARSE, reason="no isdtype")
     @pytest.mark.parametrize("dtype", ["int64", "float64"])
     def test_assert_close_tolerance(self, dtype: str, xp: ModuleType):
         a = xp.asarray([100], dtype=getattr(xp, dtype))
@@ -145,7 +139,7 @@ def test_assert_less(self, xp: ModuleType):
         with pytest.raises(AssertionError, match="Mismatched elements"):
             xp_assert_less(xp.asarray([1, 1]), xp.asarray([2, 1]))
 
-    @pytest.mark.parametrize("func", [xp_assert_equal, pr_assert_close, xp_assert_less])
+    @pytest.mark.parametrize("func", [xp_assert_equal, xp_assert_close, xp_assert_less])
     @pytest.mark.xfail_xp_backend(Backend.SPARSE, reason="index by sparse array")
     @pytest.mark.skip_xp_backend(Backend.ARRAY_API_STRICTEST, reason="boolean indexing")
     def test_none_shape(self, xp: ModuleType, func: Callable[..., None]):
@@ -176,7 +170,7 @@ def test_none_shape(self, xp: ModuleType, func: Callable[..., None]):
         with pytest.raises(AssertionError, match="Mismatched elements"):
             func(xp.asarray([4]), a)
 
-    @pytest.mark.parametrize("func", [xp_assert_equal, pr_assert_close, xp_assert_less])
+    @pytest.mark.parametrize("func", [xp_assert_equal, xp_assert_close, xp_assert_less])
     def test_device(self, xp: ModuleType, device: Device, func: Callable[..., None]):
         a = xp.asarray([1] if func is xp_assert_less else [2], device=device)
         b = xp.asarray([2], device=device)