Clean up pytorch-xfails file

Author: asmeurer

pytorch-xfails.txt

@@ -1,42 +1,51 @@
+# Note: see array_api_compat/torch/_aliases.py for links to corresponding
+# pytorch issues
+
+# We cannot wrap the array object
+
+# Indexing does not support negative step
 array_api_tests/test_array_object.py::test_getitem
 array_api_tests/test_array_object.py::test_setitem
+# Masking doesn't suport 0 dimensions in the mask
 array_api_tests/test_array_object.py::test_getitem_masking
+# torch doesn't have uint dtypes other than uint8
 array_api_tests/test_array_object.py::test_scalar_casting[__int__(uint16)]
 array_api_tests/test_array_object.py::test_scalar_casting[__int__(uint32)]
 array_api_tests/test_array_object.py::test_scalar_casting[__int__(uint64)]
 array_api_tests/test_array_object.py::test_scalar_casting[__index__(uint16)]
 array_api_tests/test_array_object.py::test_scalar_casting[__index__(uint32)]
 array_api_tests/test_array_object.py::test_scalar_casting[__index__(uint64)]
+
+# Overflow error from large inputs
 array_api_tests/test_creation_functions.py::test_arange
+# pytorch linspace bug (should be fixed in torch 2.0)
 array_api_tests/test_creation_functions.py::test_linspace
-array_api_tests/test_creation_functions.py::test_meshgrid
+
+# torch doesn't have higher uint dtypes
 array_api_tests/test_data_type_functions.py::test_iinfo[uint16]
 array_api_tests/test_data_type_functions.py::test_iinfo[uint32]
 array_api_tests/test_data_type_functions.py::test_iinfo[uint64]
+
+# --disable-extension broken with test_has_names.py
+# https://github.com/data-apis/array-api-tests/issues/169
 array_api_tests/test_has_names.py::test_has_names[linalg-matrix_transpose]
 array_api_tests/test_has_names.py::test_has_names[linalg-outer]
 array_api_tests/test_has_names.py::test_has_names[linalg-tensordot]
 array_api_tests/test_has_names.py::test_has_names[linalg-trace]
-array_api_tests/test_has_names.py::test_has_names[linear_algebra-matrix_transpose]
-array_api_tests/test_has_names.py::test_has_names[linear_algebra-vecdot]
+
+# We cannot wrap the tensor object
 array_api_tests/test_has_names.py::test_has_names[array_method-__array_namespace__]
 array_api_tests/test_has_names.py::test_has_names[array_method-to_device]
-array_api_tests/test_linalg.py::test_cross
-array_api_tests/test_linalg.py::test_eigvalsh
-array_api_tests/test_linalg.py::test_matmul
-array_api_tests/test_linalg.py::test_matrix_power
-array_api_tests/test_linalg.py::test_matrix_transpose
-array_api_tests/test_linalg.py::test_outer
-array_api_tests/test_linalg.py::test_solve
+
+
+# tensordot doesn't allow integer dtypes in some corner cases
 array_api_tests/test_linalg.py::test_tensordot
-array_api_tests/test_linalg.py::test_trace
-array_api_tests/test_linalg.py::test_vecdot
-array_api_tests/test_manipulation_functions.py::test_concat
+
+# We cannot wrap the tensor object
 array_api_tests/test_operators_and_elementwise_functions.py::test_add[__add__(x1, x2)]
 array_api_tests/test_operators_and_elementwise_functions.py::test_bitwise_and[__and__(x1, x2)]
 array_api_tests/test_operators_and_elementwise_functions.py::test_bitwise_left_shift[__lshift__(x1, x2)]
 array_api_tests/test_operators_and_elementwise_functions.py::test_bitwise_or[__or__(x1, x2)]
-array_api_tests/test_operators_and_elementwise_functions.py::test_bitwise_right_shift[bitwise_right_shift(x1, x2)]
 array_api_tests/test_operators_and_elementwise_functions.py::test_bitwise_right_shift[__rshift__(x1, x2)]
 array_api_tests/test_operators_and_elementwise_functions.py::test_bitwise_right_shift[__irshift__(x1, x2)]
 array_api_tests/test_operators_and_elementwise_functions.py::test_bitwise_xor[__xor__(x1, x2)]
@@ -47,29 +56,41 @@ array_api_tests/test_operators_and_elementwise_functions.py::test_greater[__gt__
 array_api_tests/test_operators_and_elementwise_functions.py::test_greater_equal[__ge__(x1, x2)]
 array_api_tests/test_operators_and_elementwise_functions.py::test_less[__lt__(x1, x2)]
 array_api_tests/test_operators_and_elementwise_functions.py::test_less_equal[__le__(x1, x2)]
-array_api_tests/test_operators_and_elementwise_functions.py::test_log1p
 array_api_tests/test_operators_and_elementwise_functions.py::test_multiply[__mul__(x1, x2)]
 array_api_tests/test_operators_and_elementwise_functions.py::test_pow[__pow__(x1, x2)]
-array_api_tests/test_operators_and_elementwise_functions.py::test_remainder[remainder(x1, x2)]
 array_api_tests/test_operators_and_elementwise_functions.py::test_remainder[__mod__(x1, x2)]
 array_api_tests/test_operators_and_elementwise_functions.py::test_remainder[__imod__(x1, x2)]
 array_api_tests/test_operators_and_elementwise_functions.py::test_subtract[__sub__(x1, x2)]
-array_api_tests/test_searching_functions.py::test_nonzero
+
+
+# Mac-only bug (overflow near float max)
+# array_api_tests/test_operators_and_elementwise_functions.py::test_log1p
+
+# torch doesn't handle shifting by more than the bit size correctly
+# https://github.com/pytorch/pytorch/issues/70904
+array_api_tests/test_operators_and_elementwise_functions.py::test_bitwise_right_shift[bitwise_right_shift(x1, x2)]
+# Torch bug for remainder in some cases with large values
+array_api_tests/test_operators_and_elementwise_functions.py::test_remainder[remainder(x1, x2)]
+
+# unique_all cannot be implemented because torch's unique does not support
+# returning indices
 array_api_tests/test_set_functions.py::test_unique_all
-array_api_tests/test_set_functions.py::test_unique_counts
+# unique_inverse incorrectly counts nan values
+# (https://github.com/pytorch/pytorch/issues/94106)
 array_api_tests/test_set_functions.py::test_unique_inverse
-array_api_tests/test_set_functions.py::test_unique_values
+
+# The test suite incorrectly divides by 0 here
+# (https://github.com/data-apis/array-api-tests/issues/170)
 array_api_tests/test_signatures.py::test_func_signature[floor_divide]
 array_api_tests/test_signatures.py::test_func_signature[remainder]
-array_api_tests/test_signatures.py::test_func_signature[matrix_transpose]
-array_api_tests/test_signatures.py::test_func_signature[tensordot]
-array_api_tests/test_signatures.py::test_func_signature[vecdot]
-array_api_tests/test_signatures.py::test_extension_func_signature[linalg.matrix_transpose]
-array_api_tests/test_signatures.py::test_extension_func_signature[linalg.outer]
-array_api_tests/test_signatures.py::test_extension_func_signature[linalg.tensordot]
-array_api_tests/test_signatures.py::test_extension_func_signature[linalg.trace]
+
+# We cannot add attributes to the tensor object
 array_api_tests/test_signatures.py::test_array_method_signature[__array_namespace__]
 array_api_tests/test_signatures.py::test_array_method_signature[to_device]
+
+
+# We do not attempt to work around special-case differences (most are on
+# tensor methods which we couldn't fix anyway).
 array_api_tests/test_special_cases.py::test_binary[add(isfinite(x1_i) and x1_i != 0 and x2_i == -x1_i) -> +0]
 array_api_tests/test_special_cases.py::test_binary[__add__(x1_i is +infinity and isfinite(x2_i)) -> +infinity]
 array_api_tests/test_special_cases.py::test_binary[__add__(isfinite(x1_i) and x2_i is +infinity) -> +infinity]
@@ -145,7 +166,11 @@ array_api_tests/test_special_cases.py::test_empty_arrays[std]
 array_api_tests/test_special_cases.py::test_empty_arrays[var]
 array_api_tests/test_special_cases.py::test_nan_propagation[std]
 array_api_tests/test_special_cases.py::test_nan_propagation[var]
-array_api_tests/test_statistical_functions.py::test_prod
+
+# Float correction is not supported by pytorch (https://github.com/data-apis/array-api-tests/issues/168)
 array_api_tests/test_statistical_functions.py::test_std
-array_api_tests/test_statistical_functions.py::test_sum
 array_api_tests/test_statistical_functions.py::test_var
+
+# The test suite is incorrectly checking sums that have loss of significance
+# (https://github.com/data-apis/array-api-tests/issues/168)
+array_api_tests/test_statistical_functions.py::test_sum