feat(sml): version is mandatory for SML entry (#289)

* feat(sml): version is mandatory for sml entry

* feat: clone thisˆ

Author: shumkov

lib/deterministicmnlist/SimplifiedMNListDiff.js

@@ -219,7 +219,7 @@ SimplifiedMNListDiff.fromObject = function fromObject(obj, network) {
   // Copy array of strings
   simplifiedMNListDiff.deletedMNs = obj.deletedMNs.slice();
   simplifiedMNListDiff.mnList = obj.mnList.map(
-    (entry) => new SimplifiedMNListEntry({ ...entry, nVersion: obj.nVersion }, validNetwork)
+    (entry) => new SimplifiedMNListEntry(entry, validNetwork)
   );
   simplifiedMNListDiff.deletedQuorums = obj.deletedQuorums.slice();
   simplifiedMNListDiff.newQuorums = obj.newQuorums.map(
@@ -296,7 +296,7 @@ SimplifiedMNListDiff.prototype.toObject = function toObject() {
 };
 
 SimplifiedMNListDiff.prototype.copy = function copy() {
-  return SimplifiedMNListDiff.fromObject(_.clone(this.toObject()), this.network);
+  return _.cloneDeep(this);
 };
 
 module.exports = SimplifiedMNListDiff;

lib/deterministicmnlist/SimplifiedMNListEntry.js

@@ -148,12 +148,14 @@ SimplifiedMNListEntry.prototype.toBuffer = function toBuffer() {
   );
   bufferWriter.writeUInt8(Number(this.isValid));
 
-  if (typeof this.nType === 'number') {
-    bufferWriter.writeUInt16LE(this.nType);
-
-    if (this.nType === MASTERNODE_TYPE_HP) {
-      bufferWriter.writeUInt16LE(this.platformHTTPPort);
-      bufferWriter.write(Buffer.from(this.platformNodeID, 'hex').reverse());
+  if (this.nVersion === 2) {
+    if (typeof this.nType === 'number') {
+      bufferWriter.writeUInt16LE(this.nType);
+
+      if (this.nType === MASTERNODE_TYPE_HP) {
+        bufferWriter.writeUInt16LE(this.platformHTTPPort);
+        bufferWriter.write(Buffer.from(this.platformNodeID, 'hex').reverse());
+      }
     }
   }
 
@@ -239,9 +241,12 @@ SimplifiedMNListEntry.prototype.toObject = function toObject() {
     pubKeyOperator: this.pubKeyOperator,
     votingAddress: this.votingAddress,
     isValid: this.isValid,
-    nVersion: this.nVersion,
   };
 
+  if (typeof this.nVersion === 'number') {
+    result.nVersion = this.nVersion;
+  }
+
   if (typeof this.nType === 'number') {
     result.nType = this.nType;
   }
@@ -262,10 +267,6 @@ SimplifiedMNListEntry.prototype.toObject = function toObject() {
     result.platformNodeID = this.platformNodeID;
   }
 
-  if (typeof this.nVersion === 'number') {
-    result.nVersion = this.nVersion;
-  }
-
   return result;
 };
 
@@ -302,7 +303,7 @@ SimplifiedMNListEntry.prototype.confirmedHashWithProRegTxHash =
  * @return {SimplifiedMNListEntry}
  */
 SimplifiedMNListEntry.prototype.copy = function copy() {
-  return SimplifiedMNListEntry.fromObject(_.clone(this.toObject()), this.network);
+  return _.cloneDeep(this);
 };
 
 module.exports = SimplifiedMNListEntry;