update package:gcloud to a more recent set of lints (#229)

Author: devoncarew

pkgs/gcloud/.status

@@ -61,7 +61,8 @@ class DatastoreError implements Exception {
 }
 
 class UnknownDatastoreError extends DatastoreError {
-  UnknownDatastoreError(error) : super('An unknown error occurred ($error).');
+  UnknownDatastoreError(Object error)
+      : super('An unknown error occurred ($error).');
 }
 
 class TransactionAbortedError extends DatastoreError {
@@ -89,7 +90,7 @@ class InternalError extends DatastoreError {
 }
 
 class QuotaExceededError extends DatastoreError {
-  QuotaExceededError(error) : super('Quota was exceeded ($error).');
+  QuotaExceededError(Object error) : super('Quota was exceeded ($error).');
 }
 
 /// A datastore Entity

pkgs/gcloud/lib/datastore.dart

@@ -2,8 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-library;
-
 import 'dart:collection';
 // dart:core is imported explicitly so it is available at top-level without
 //   the `core` prefix defined below.

pkgs/gcloud/lib/db.dart

@@ -102,8 +102,7 @@ Future fork(Future Function() func, {Function? onError}) {
   return currentServiceScope._fork(func, onError: onError);
 }
 
-/// Register a new [object] into the current service scope using the given
-/// [key].
+/// Register [value] into the current service scope using the given [key].
 ///
 /// If [onScopeExit] is provided, it will be called when the service scope ends.
 ///
@@ -240,7 +239,7 @@ class _ServiceScope {
   /// Runs all on-scope-exit functions in [_ServiceScope].
   Future _runScopeExitHandlers() {
     _cleaningUp = true;
-    var errors = [];
+    var errors = <Object>[];
 
     // We are running all on-scope-exit functions in reverse registration order.
     // Even if one fails, we continue cleaning up and report then the list of
@@ -252,7 +251,7 @@ class _ServiceScope {
       }
       if (registeredEntry.scopeExitCallback != null) {
         return Future.sync(registeredEntry.scopeExitCallback!)
-            .catchError((e, s) => errors.add(e));
+            .catchError((Object e, s) => errors.add(e));
       } else {
         return Future.value();
       }

pkgs/gcloud/lib/service_scope.dart

@@ -106,7 +106,7 @@ class DatastoreImpl implements datastore.Datastore {
     return true;
   }
 
-  api.Value _convertDatastore2ApiPropertyValue(value, bool indexed,
+  api.Value _convertDatastore2ApiPropertyValue(Object? value, bool indexed,
       {bool lists = true}) {
     var apiValue = api.Value()..excludeFromIndexes = !indexed;
     if (value == null) {
@@ -132,8 +132,8 @@ class DatastoreImpl implements datastore.Datastore {
         throw Exception('List values are not allowed.');
       }
 
-      api.Value convertItem(i) =>
-          _convertDatastore2ApiPropertyValue(i, indexed, lists: false);
+      api.Value convertItem(Object? item) =>
+          _convertDatastore2ApiPropertyValue(item, indexed, lists: false);
 
       return api.Value()
         ..arrayValue =

pkgs/gcloud/lib/src/datastore_impl.dart

@@ -35,7 +35,7 @@ class Kind {
   /// annotation is placed.
   final String? name;
 
-  /// The type, either [ID_TYPE_INTEGER] or [ID_TYPE_STRING].
+  /// The type, either [IdType.Integer] or [IdType.String].
   final IdType idType;
 
   /// Annotation specifying the name of this kind and whether to use integer or
@@ -102,9 +102,7 @@ abstract class Property {
 /// An abstract base class for primitive properties which can e.g. be used
 /// within a composed `ListProperty`.
 abstract class PrimitiveProperty extends Property {
-  const PrimitiveProperty(
-      {String? propertyName, bool required = false, bool indexed = true})
-      : super(propertyName: propertyName, required: required, indexed: indexed);
+  const PrimitiveProperty({super.propertyName, super.required, super.indexed});
 
   @override
   Object? encodeValue(ModelDB db, Object? value,
@@ -120,9 +118,7 @@ abstract class PrimitiveProperty extends Property {
 /// It will validate that values are booleans before writing them to the
 /// datastore and when reading them back.
 class BoolProperty extends PrimitiveProperty {
-  const BoolProperty(
-      {String? propertyName, bool required = false, bool indexed = true})
-      : super(propertyName: propertyName, required: required, indexed: indexed);
+  const BoolProperty({super.propertyName, super.required, super.indexed});
 
   @override
   bool validate(ModelDB db, Object? value) =>
@@ -134,9 +130,7 @@ class BoolProperty extends PrimitiveProperty {
 /// It will validate that values are integers before writing them to the
 /// datastore and when reading them back.
 class IntProperty extends PrimitiveProperty {
-  const IntProperty(
-      {String? propertyName, bool required = false, bool indexed = true})
-      : super(propertyName: propertyName, required: required, indexed: indexed);
+  const IntProperty({super.propertyName, super.required, super.indexed});
 
   @override
   bool validate(ModelDB db, Object? value) =>
@@ -148,9 +142,7 @@ class IntProperty extends PrimitiveProperty {
 /// It will validate that values are doubles before writing them to the
 /// datastore and when reading them back.
 class DoubleProperty extends PrimitiveProperty {
-  const DoubleProperty(
-      {String? propertyName, bool required = false, bool indexed = true})
-      : super(propertyName: propertyName, required: required, indexed: indexed);
+  const DoubleProperty({super.propertyName, super.required, super.indexed});
 
   @override
   bool validate(ModelDB db, Object? value) =>
@@ -162,9 +154,7 @@ class DoubleProperty extends PrimitiveProperty {
 /// It will validate that values are strings before writing them to the
 /// datastore and when reading them back.
 class StringProperty extends PrimitiveProperty {
-  const StringProperty(
-      {String? propertyName, bool required = false, bool indexed = true})
-      : super(propertyName: propertyName, required: required, indexed: indexed);
+  const StringProperty({super.propertyName, super.required, super.indexed});
 
   @override
   bool validate(ModelDB db, Object? value) =>
@@ -176,9 +166,7 @@ class StringProperty extends PrimitiveProperty {
 /// It will validate that values are keys before writing them to the
 /// datastore and when reading them back.
 class ModelKeyProperty extends PrimitiveProperty {
-  const ModelKeyProperty(
-      {String? propertyName, bool required = false, bool indexed = true})
-      : super(propertyName: propertyName, required: required, indexed: indexed);
+  const ModelKeyProperty({super.propertyName, super.required, super.indexed});
 
   @override
   bool validate(ModelDB db, Object? value) =>
@@ -201,10 +189,10 @@ class ModelKeyProperty extends PrimitiveProperty {
 ///
 /// It will validate that values are blobs before writing them to the
 /// datastore and when reading them back. Blob values will be represented by
-/// List<int>.
+/// `List<int>`.
 class BlobProperty extends PrimitiveProperty {
-  const BlobProperty({String? propertyName, bool required = false})
-      : super(propertyName: propertyName, required: required, indexed: false);
+  const BlobProperty({super.propertyName, super.required})
+      : super(indexed: false);
 
   // NOTE: We don't validate that the entries of the list are really integers
   // of the range 0..255!
@@ -233,9 +221,7 @@ class BlobProperty extends PrimitiveProperty {
 /// It will validate that values are DateTime objects before writing them to the
 /// datastore and when reading them back.
 class DateTimeProperty extends PrimitiveProperty {
-  const DateTimeProperty(
-      {String? propertyName, bool required = false, bool indexed = true})
-      : super(propertyName: propertyName, required: required, indexed: indexed);
+  const DateTimeProperty({super.propertyName, super.required, super.indexed});
 
   @override
   bool validate(ModelDB db, Object? value) =>
@@ -260,9 +246,8 @@ class ListProperty extends Property {
 
   // TODO: We want to support optional list properties as well.
   // Get rid of "required: true" here.
-  const ListProperty(this.subProperty,
-      {String? propertyName, bool indexed = true})
-      : super(propertyName: propertyName, required: true, indexed: indexed);
+  const ListProperty(this.subProperty, {super.propertyName, super.indexed})
+      : super(required: true);
 
   @override
   bool validate(ModelDB db, Object? value) {

pkgs/gcloud/lib/src/db/annotations.dart

@@ -85,7 +85,7 @@ class Transaction {
     }
   }
 
-  /// Query for [kind] models with [ancestorKey].
+  /// Query for kind models with [ancestorKey].
   ///
   /// Note that [ancestorKey] is required, since a transaction is not allowed to
   /// touch/look at an arbitrary number of rows.
@@ -325,7 +325,7 @@ class DatastoreDB {
     });
   }
 
-  /// Build a query for [kind] models.
+  /// Build a query for kind models.
   Query<T> query<T extends Model>({Partition? partition, Key? ancestorKey}) {
     // TODO(#26): There is only one case where `partition` is not redundant
     // Namely if `ancestorKey == null` and `partition != null`. We could
@@ -350,8 +350,8 @@ class DatastoreDB {
   /// Any key that is not found in the datastore will have a corresponding
   /// value of null in the list of model objects that is returned.
   ///
-  /// For transactions, please use [beginTransaction] and call the [lookup]
-  /// method on it's returned [Transaction] object.
+  /// For transactions, please use [ds.Datastore.beginTransaction] and call the
+  /// [lookup] method on it's returned [Transaction] object.
   ///
   /// See also:
   ///

pkgs/gcloud/lib/src/db/db.dart

@@ -168,7 +168,7 @@ class ModelDBImpl implements ModelDB {
     return modelDescription.fieldNameToPropertyName(fieldName);
   }
 
-  /// Converts [value] according to the [Property] named [name] in [type].
+  /// Converts [value] according to the given [kind].
   @override
   Object? toDatastoreValue(String kind, String fieldName, Object? value,
       {bool forComparison = false}) {
@@ -528,8 +528,7 @@ class _ExpandoModelDescription extends _ModelDescription<ExpandoModel> {
   late Set<String> realPropertyNames;
   late Set<String> usedNames;
 
-  _ExpandoModelDescription(String kind, bool useIntegerId)
-      : super(kind, useIntegerId);
+  _ExpandoModelDescription(super.kind, super.useIntegerId);
 
   @override
   void initialize(ModelDBImpl db) {

pkgs/gcloud/lib/src/db/model_db_impl.dart

@@ -111,7 +111,7 @@ abstract class Model<T> {
 ///
 /// The [ExpandoModel] class adds support for having dynamic properties. You can
 /// set arbitrary fields on these models. The expanded values must be values
-/// accepted by the [RawDatastore] implementation.
+/// accepted by the [ds.Datastore] implementation.
 abstract class ExpandoModel<T> extends Model<T> {
   final Map<String, Object?> additionalProperties = {};
 

pkgs/gcloud/lib/src/db/models.dart

@@ -71,7 +71,7 @@ class _StorageImpl implements Storage {
 
   @override
   Future<bool> bucketExists(String bucketName) {
-    bool notFoundError(e) {
+    bool notFoundError(Object e) {
       return e is storage_api.DetailedApiRequestError && e.status == 404;
     }
 
@@ -431,7 +431,7 @@ class _ObjectInfoImpl implements ObjectInfo {
 }
 
 class _BucketObjectEntry extends _ObjectInfoImpl implements BucketObjectEntry {
-  _BucketObjectEntry(storage_api.Object object) : super(object);
+  _BucketObjectEntry(super.object);
 
   @override
   bool get isDirectory => false;