Enable and fix new team lints, require Dart 2.19 (dart-archive/gcloud#155)

Author: kevmoo

pkgs/gcloud/.github/workflows/test-package.yml

@@ -47,7 +47,7 @@ jobs:
       matrix:
         # Add macos-latest and/or windows-latest if relevant for this package.
         os: [ubuntu-latest]
-        sdk: [2.12.0, dev]
+        sdk: [2.19.0, dev]
     steps:
       - uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c
       - uses: dart-lang/setup-dart@a57a6c04cf7d4840e88432aad6281d1e125f0d46

pkgs/gcloud/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.8.8-dev
+
+- Require Dart 2.19
+
 ## 0.8.7
 
 - Fix `Bucket.write` when size is below 1MB.

pkgs/gcloud/analysis_options.yaml

@@ -1,23 +1,12 @@
-include: package:lints/recommended.yaml
+include: package:dart_flutter_team_lints/analysis_options.yaml
 
 analyzer:
   language:
     strict-casts: true
 
 linter:
   rules:
-    - await_only_futures
-    - camel_case_types
     - cancel_subscriptions
-    - control_flow_in_finally
-    - directives_ordering
-    - empty_statements
-    - iterable_contains_unrelated_type
-    - list_remove_unrelated_type
     - package_api_docs
-    - package_names
-    - package_prefixed_library_names
     - prefer_relative_imports
     - test_types_in_equals
-    - throw_in_finally
-    - unnecessary_brace_in_string_interps

pkgs/gcloud/lib/common.dart

@@ -2,8 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-library gcloud.common;
-
 import 'dart:async';
 
 /// A single page of paged results from a query.

pkgs/gcloud/lib/datastore.dart

@@ -7,7 +7,7 @@
 ///
 /// For more information on Cloud Datastore, please refer to the following
 /// developers page: https://cloud.google.com/datastore/docs
-library gcloud.datastore;
+library;
 
 import 'dart:async';
 
@@ -52,7 +52,7 @@ class DatastoreError implements Exception {
   final String message;
 
   DatastoreError([String? message])
-      : message = (message ?? 'DatastoreError: An unknown error occured');
+      : message = message ?? 'DatastoreError: An unknown error occured';
 
   @override
   String toString() => message;

pkgs/gcloud/lib/db.dart

@@ -2,7 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-library gcloud.db;
+library;
 
 import 'dart:collection';
 // dart:core is imported explicitly so it is available at top-level without

pkgs/gcloud/lib/db/metamodel.dart

@@ -2,8 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-library gcloud.db.meta_model;
-
 import '../db.dart' as db;
 
 @db.Kind(name: '__namespace__')

pkgs/gcloud/lib/http.dart

@@ -4,7 +4,7 @@
 
 /// Provides access to an authenticated HTTP client which can be used to access
 /// Google APIs.
-library gcloud.http;
+library;
 
 import 'package:http/http.dart' as http;
 

pkgs/gcloud/lib/pubsub.dart

@@ -2,8 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-library gcloud.pubsub;
-
 import 'dart:async';
 import 'dart:collection';
 import 'dart:convert';

pkgs/gcloud/lib/service_scope.dart

@@ -72,7 +72,7 @@
 /// and instead depend only on the services needed (e.g.
 /// `package:gcloud/storage.dart`) by using getters in the service library (e.g.
 /// the `storageService`) which are implemented with service scope lookups.
-library gcloud.service_scope;
+library;
 
 import 'dart:async';