add a CI; rev version in prep for publishing

Author: devoncarew

pkgs/appengine/.github/dependabot.yaml

@@ -0,0 +1,8 @@
+# Dependabot configuration file.
+version: 2
+
+updates:
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "monthly"

pkgs/appengine/.github/workflows/build.yaml

@@ -0,0 +1,31 @@
+name: Build
+
+on:
+  schedule:
+    # “At 00:00 (UTC) on Sunday.”
+    - cron: '0 0 * * 0'
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
+      - uses: dart-lang/setup-dart@6a218f2413a3e78e9087f638a238f6b40893203d
+
+      - name: Install dependencies
+        run: dart pub get
+  
+      # Disabled - this would format ~492 files.
+      # - name: Verify formatting
+      #   run: dart format --output=none --set-exit-if-changed .
+
+      - name: Analyze project source
+        run: dart analyze --fatal-infos
+
+      - name: Run tests
+        run: dart test

pkgs/appengine/CHANGELOG.md

@@ -1,4 +1,7 @@
-## 0.13.3-dev
+## 0.13.3
+
+* Populate the pubspec `repository` field.
+* Update the readme to add experimental verbiage.
 
 ## 0.13.2
  * Gracefully handle cases where logging fails.

pkgs/appengine/README.md

@@ -1,4 +1,8 @@
-# Dart support for Google AppEngine
+[![Build Status](https://github.com/dart-lang/appengine/workflows/Dart/badge.svg)](https://github.com/dart-lang/appengine/actions)
+[![pub package](https://img.shields.io/pub/v/appengine.svg)](https://pub.dev/packages/appengine)
+[![package publisher](https://img.shields.io/pub/publisher/appengine.svg)](https://pub.dev/packages/appengine/publisher)
+
+## Dart support for Google AppEngine
 
 This package provides support for running server applications written in Dart on
 [Google App Engine](https://cloud.google.com/appengine/) using

pkgs/appengine/analysis_options.yaml

@@ -1 +1,6 @@
 include: package:pedantic/analysis_options.1.8.0.yaml
+
+analyzer:
+  errors:
+    # This is triggered in generated code.
+    unnecessary_import: ignore

pkgs/appengine/lib/src/server/logging_package_adaptor.dart

@@ -37,7 +37,7 @@ void setupAppEngineLogging() {
         if (level != null) {
           var message = record.message;
 
-          if (record.loggerName != null && record.loggerName.isNotEmpty) {
+          if (record.loggerName.isNotEmpty) {
             message = '${record.loggerName}: $message';
           }
 

pkgs/appengine/pubspec.yaml

@@ -1,8 +1,8 @@
 name: appengine
-version: 0.13.3-dev
-description: >-
-  Support for using Dart as a custom runtime on
-  Google App Engine Flexible Environment
+version: 0.13.3
+description: >
+  Support for using Dart as a custom runtime on Google App Engine Flexible
+  Environment
 repository: https://github.com/dart-lang/appengine
 
 environment:
@@ -20,5 +20,5 @@ dependencies:
   stack_trace: ^1.10.0
 
 dev_dependencies:
-  test: ^1.17.5
   pedantic: ^1.11.0
+  test: ^1.17.5

pkgs/appengine/test/integration/db/metamodel_tests.dart

@@ -56,31 +56,46 @@ runTests(datastore, db.DatastoreDB store, String uniquePostfix) {
 
       expect(namespaces.length, greaterThanOrEqualTo(3));
       expect(namespaces, contains(cond((dynamic ns) => ns.name == null)));
-      expect(namespaces, contains(cond((dynamic ns) => ns.name == 'FooNamespace')));
-      expect(namespaces, contains(cond((dynamic ns) => ns.name == 'BarNamespace')));
+      expect(namespaces,
+          contains(cond((dynamic ns) => ns.name == 'FooNamespace')));
+      expect(namespaces,
+          contains(cond((dynamic ns) => ns.name == 'BarNamespace')));
 
       try {
         for (final namespace in [null, 'FooNamespace', 'BarNamespace']) {
-          final partition = store.newPartition(namespace!);
+          // TODO: Partition.newPartition should be updated to accept null.
+          final partition = store.newPartition(namespace ?? '');
           final kindQuery = store.query<Kind>(partition: partition);
           final List<Kind> kinds = await kindQuery.run().cast<Kind>().toList();
 
           expect(kinds.length, greaterThanOrEqualTo(2));
           if (namespace == null) {
-            expect(kinds,
-                contains(cond((dynamic k) => k.name == 'NullKind$uniquePostfix')));
-            expect(kinds,
-                contains(cond((dynamic k) => k.name == 'NullKind2$uniquePostfix')));
+            expect(
+                kinds,
+                contains(
+                    cond((dynamic k) => k.name == 'NullKind$uniquePostfix')));
+            expect(
+                kinds,
+                contains(
+                    cond((dynamic k) => k.name == 'NullKind2$uniquePostfix')));
           } else if (namespace == 'FooNamespace') {
-            expect(kinds,
-                contains(cond((dynamic k) => k.name == 'FooKind$uniquePostfix')));
-            expect(kinds,
-                contains(cond((dynamic k) => k.name == 'FooKind2$uniquePostfix')));
+            expect(
+                kinds,
+                contains(
+                    cond((dynamic k) => k.name == 'FooKind$uniquePostfix')));
+            expect(
+                kinds,
+                contains(
+                    cond((dynamic k) => k.name == 'FooKind2$uniquePostfix')));
           } else if (namespace == 'BarNamespace') {
-            expect(kinds,
-                contains(cond((dynamic k) => k.name == 'BarKind$uniquePostfix')));
-            expect(kinds,
-                contains(cond((dynamic k) => k.name == 'BarKind2$uniquePostfix')));
+            expect(
+                kinds,
+                contains(
+                    cond((dynamic k) => k.name == 'BarKind$uniquePostfix')));
+            expect(
+                kinds,
+                contains(
+                    cond((dynamic k) => k.name == 'BarKind2$uniquePostfix')));
           }
         }
       } finally {

pkgs/appengine/test/integration/grpc_datastore_test.dart

@@ -4,15 +4,12 @@
 
 import 'dart:io';
 
-import 'package:test/test.dart' as test;
-
-import 'package:grpc/grpc.dart' as grpc;
 import 'package:appengine/src/grpc_api_impl/datastore_impl.dart';
 import 'package:gcloud/db.dart' as db;
+import 'package:grpc/grpc.dart' as grpc;
+import 'package:test/test.dart' as test;
 
 import 'common_e2e.dart' show withAuthenticator;
-import 'db/db_tests.dart' as db_tests;
-import 'db/metamodel_tests.dart' as metamodel_tests;
 import 'raw_datastore_test_impl.dart' as datastore_tests;
 
 main() async {
@@ -24,6 +21,7 @@ main() async {
       (String project, grpc.HttpBasedAuthenticator authenticator) async {
     final clientChannel = grpc.ClientChannel(endpoint);
     final datastore = GrpcDatastoreImpl(clientChannel, authenticator, project);
+    // ignore: unused_local_variable
     final dbService = db.DatastoreDB(datastore);
 
     // Once all tests are done we'll close the resources.

pkgs/appengine/test/integration/raw_datastore_test_impl.dart

@@ -113,7 +113,6 @@ runTests(Datastore datastore, String namespace) {
     if (key.elements.isEmpty) return false;
 
     for (var element in key.elements) {
-      if (element.kind is! String) return false;
       if (!ignoreIds) {
         if (element.id == null ||
             (element.id is! String && element.id is! int)) {