Handle errors correctly when logging fails (dart-archive/appengine#148)

Author: jonasfj

pkgs/appengine/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 0.13.2
+ * Gracefully handle cases where logging fails.
+
 ## 0.13.1
  * Fix dependency on `package:gcloud` to version `0.8.0`.
 

pkgs/appengine/lib/src/grpc_api_impl/logging_impl.dart

@@ -371,17 +371,21 @@ class SharedLoggingService {
       ..partialSuccess =
           false /* for now we want to get notified if something goes wrong */;
     _entries.clear();
-    _clientStub.writeLogEntries(request).catchError((error, stack) {
-      // In case the logging API failed, we'll write the error message to
-      // stderr.  The logging daemon on the VM will make another attempt at
-      // uploading stderr via the logging API.
-      stderr.writeln('An error occured while writing log entries:\n'
-          'Error:$error\n'
-          '$stack');
-    }).whenComplete(() {
-      _outstandingRequests--;
-      _maybeClose();
-    });
+    unawaited(() async {
+      try {
+        await _clientStub.writeLogEntries(request);
+      } catch (error, stack) {
+        // In case the logging API failed, we'll write the error message to
+        // stderr.  The logging daemon on the VM will make another attempt at
+        // uploading stderr via the logging API.
+        stderr.writeln('An error occured while writing log entries:\n'
+            'Error:$error\n'
+            '$stack');
+      } finally {
+        _outstandingRequests--;
+        _maybeClose();
+      }
+    }());
   }
 
   Future close() {

pkgs/appengine/pubspec.yaml

@@ -1,12 +1,12 @@
 name: appengine
-version: 0.13.1
+version: 0.13.2
 description: >-
   Support for using Dart as a custom runtime on
   Google App Engine Flexible Environment
 homepage: https://github.com/dart-lang/appengine
 
 environment:
-  sdk: '>=2.12.0 <3.0.0'
+  sdk: '>=2.14.0 <3.0.0'
 
 dependencies:
   fixnum: ^1.0.0