Skip to content

Some tests need to be updated due to feature getter-setter-error being enabled by default #3201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chloestefantsova opened this issue May 23, 2025 · 0 comments
Closed

Some tests need to be updated due to feature getter-setter-error being enabled by default #3201

chloestefantsova opened this issue May 23, 2025 · 0 comments
Assignees
@sgrekhov
Labels
type-enhancement A request for a change that isn't a bug

Comments

@chloestefantsova
Copy link
Contributor

chloestefantsova commented May 23, 2025 •
edited
Loading

With the getter-setter-error feature enabled by this CL, the setter/getter pair with mismatching types isn't treated as an error any longer. The following tests should be updated to account for that, after the CL is landed:

  • co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A03_t04
  • co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A30_t01
  • co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A30_t02
  • co19/LanguageFeatures/Extension-types/static_analysis_extension_types_A30_t03
  • co19/LanguageFeatures/Extension-types/static_analysis_member_invocation_A06_t04
  • co19/LanguageFeatures/Extension-types/static_analysis_member_invocation_A08_t05
  • co19/Language/Classes/Instance_Variables/covariant_A04_t01
  • co19/Language/Classes/Instance_Variables/covariant_A04_t04
  • co19/Language/Classes/Setters/same_name_getter_different_type_t01
  • co19/Language/Classes/Setters/same_name_getter_different_type_t02
  • co19/LanguageFeatures/Enhanced-Enum/grammar_A10_t04
  • co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t08
  • co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t12
  • co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t20
  • co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t24
  • co19/LanguageFeatures/Enhanced-Enum/semantics_A09_t05
  • co19/LanguageFeatures/Enhanced-Enum/semantics_A09_t11
  • co19/LanguageFeatures/nnbd/static_errors_A31_t01
  • co19/LanguageFeatures/nnbd/static_errors_A31_t02
  • co19/Language/Classes/Instance_Variables/covariant_A04_t01
  • co19/Language/Classes/Instance_Variables/covariant_A04_t04
  • co19/Language/Classes/Setters/same_name_getter_different_type_t01
  • co19/Language/Classes/Setters/same_name_getter_different_type_t02
  • co19/LanguageFeatures/Enhanced-Enum/grammar_A10_t04
  • co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t08
  • co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t12
  • co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t20
  • co19/LanguageFeatures/Enhanced-Enum/implementing_enum_A04_t24
  • co19/LanguageFeatures/Enhanced-Enum/semantics_A09_t05
  • co19/LanguageFeatures/Enhanced-Enum/semantics_A09_t11
  • co19/LanguageFeatures/nnbd/static_errors_A31_t01
  • co19/LanguageFeatures/nnbd/static_errors_A31_t02
@sgrekhov sgrekhov self-assigned this May 23, 2025
@sgrekhov sgrekhov added the type-enhancement A request for a change that isn't a bug label May 23, 2025
sgrekhov added a commit to sgrekhov/co19 that referenced this issue May 28, 2025
@sgrekhov
Fixes dart-lang#3201. Allow getter/setter with different types
bba31bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chloestefantsova @sgrekhov