Refactor & remove tryStopRecording

Author: darshanparajuli

app/src/main/java/com/dp/logcatapp/activities/MainActivity.kt

@@ -88,7 +88,7 @@ class MainActivity : BaseActivityWithToolbar() {
     if (intent?.getBooleanExtra(STOP_RECORDING_EXTRA, false) == true) {
       val fragment = supportFragmentManager.findFragmentByTag(LogcatLiveFragment.TAG)
       if (fragment != null) {
-        (fragment as LogcatLiveFragment).tryStopRecording()
+        (fragment as LogcatLiveFragment).stopRecording()
       }
     }
   }

app/src/main/java/com/dp/logcatapp/fragments/logcatlive/LogcatLiveFragment.kt

@@ -617,19 +617,13 @@ class LogcatLiveFragment : BaseFragment(), ServiceConnection, LogsReceivedListen
     startActivity(intent)
   }
 
-  fun tryStopRecording() {
+  fun stopRecording() {
     viewModel.stopRecording = true
-    if (logcatService != null) {
-      stopRecording()
-    }
-  }
-
-  private fun stopRecording() {
-    logcatService.value?.let {
-      if (it.recording) {
-        it.updateNotification(false)
+    logcatService.value?.let { service ->
+      if (service.recording) {
+        service.updateNotification(false)
         saveToFile(true)
-        it.recording = false
+        service.recording = false
         activity?.invalidateOptionsMenu()
       }
     }