-
Notifications
You must be signed in to change notification settings - Fork 209
feat: ignore scheduler and placement connect #1528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Gallardot <gallardot@apache.org>
placementHostAddr = "localhost" | ||
} | ||
|
||
if strings.TrimSpace(placementHostAddr) == "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"localhost" is being assigned above in line 130 if placementHostAddr is empty, so this check could never be true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"localhost" is being assigned above in line 130 if placementHostAddr is empty, so this check could never be true
Hi @yaron2 , Thanks for your reply.
Here is an example:
dapr run --placement-host-address " " --scheduler-host-address " " -a app-id
This is different from "empty". The part I modified is to handle such cases. I think it is OK.
When using the CLI, ensure that the provided capabilities are consistent with those of the annotations.
Comma separated list of addresses for Dapr Actor Placement servers.
When no annotation is set, the default value is set by the Sidecar Injector.
When the annotation is set and the value is a single space (' '), or “empty”, the sidecar does not connect to Placement server. This can be used when there are no actors running in the sidecar.
When the annotation is set and the value is not empty, the sidecar connects to the configured address. For example: 127.0.0.1:50057,127.0.0.1:50058
For reference, please see:
https://docs.dapr.io/reference/arguments-annotations-overview/
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Hello @yaron2 Could you please take a look again? |
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Signed-off-by: Gallardot <gallardot@apache.org>
Description
Please explain the changes you've made
Issue reference
#1503
https://docs.dapr.io/reference/arguments-annotations-overview/
Sometimes when developing locally, we don't need placement and scheduler.
When using cli, provide capabilities consistent with annotation.
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: