Skip to content

Conversation

antontroshin
Copy link
Contributor

Description

Call metadata endpoint and update the dapr cli PID, app PID and app command in a separate goroutine to avoid blocking termination signals.
For example, when "dapr run" initialization fails with fatal errors on component init errors.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1338

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Anton Troshin <18515134+antontroshin@users.noreply.github.com>
@antontroshin antontroshin marked this pull request as ready for review July 4, 2025 07:24
@antontroshin antontroshin requested review from a team as code owners July 4, 2025 07:24
@antontroshin antontroshin changed the title fix: ensure proper handling of termination signals and metadata updates [DO NOT MERGE] fix: ensure proper handling of termination signals and metadata updates Aug 15, 2025
@antontroshin
Copy link
Contributor Author

Some tests are failing due to the app closing faster, and the expected logs do not appear.
Will check it out.

@dapr-bot
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added the stale label Sep 14, 2025
@dapr-bot
Copy link
Collaborator

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot closed this Sep 21, 2025
@yaron2 yaron2 reopened this Sep 21, 2025
@dapr-bot dapr-bot removed the stale label Sep 21, 2025
@dapr-bot
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added stale and removed stale labels Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't Ctrl-C Early on dapr run w/o Necessary Component, Forced to Wait After Seeing Initial Err

3 participants