Make rich text action implement label protocol

Author: danielsaidi

RELEASE_NOTES.md

@@ -17,8 +17,9 @@ This release starts moving types and views that relate to other types into the t
 * `RichTextLabelValue` is a new protocol to harmonize label-compatible label values.
 
 ### 💡 Adjustments
-              
+
 * Many value types implement `RichTextLabelValue` to get a `label` property.
+* All types that implement `RichTextLabelValue` get a `label` that has improved accessibility.
 
 ### 🐛 Bug Fixes
 

Sources/RichTextKit/Actions/RichTextAction+Button.swift

@@ -44,12 +44,12 @@ public extension RichTextAction {
 
         public var body: some View {
             SwiftUI.Button(action: triggerAction) {
-                action.icon
+                action.label
+                    .labelStyle(.iconOnly)
                     .frame(maxHeight: fillVertically ? .infinity : nil)
                     .contentShape(Rectangle())
             }
             .keyboardShortcut(for: action)
-            .accessibilityLabel(action.title)
             .disabled(!context.canHandle(action))
         }
     }
@@ -68,48 +68,50 @@ struct RichTextAction_Button_Previews: PreviewProvider {
 
         @StateObject
         private var context = RichTextContext()
+        
+        func button(
+            for action: RichTextAction
+        ) -> some View {
+            RichTextAction.Button(
+                action: action,
+                context: context,
+                fillVertically: true
+            )
+        }
 
         var body: some View {
-            HStack {
-                RichTextAction.Button(
-                    action: .copy,
-                    context: context,
-                    fillVertically: true
-                )
-                RichTextAction.Button(
-                    action: .redoLatestChange,
-                    context: context,
-                    fillVertically: true
-                )
-                RichTextAction.Button(
-                    action: .undoLatestChange,
-                    context: context,
-                    fillVertically: true
-                )
-                RichTextAction.Button(
-                    action: .stepFontSize(points: 1),
-                    context: context,
-                    fillVertically: true
-                )
-                RichTextAction.Button(
-                    action: .stepFontSize(points: -1),
-                    context: context,
-                    fillVertically: true
-                )
-                RichTextAction.Button(
-                    action: .decreaseIndent(),
-                    context: context,
-                    fillVertically: true
-                )
-                RichTextAction.Button(
-                    action: .increaseIndent(),
-                    context: context,
-                    fillVertically: true
-                )
+            VStack {
+                Group {
+                    HStack {
+                        button(for: .copy)
+                        button(for: .dismissKeyboard)
+                        button(for: .print)
+                        button(for: .redoLatestChange)
+                        button(for: .undoLatestChange)
+                    }
+                    HStack {
+                        ForEach(RichTextAlignment.allCases) {
+                            button(for: .setAlignment($0))
+                        }
+                    }
+                    HStack {
+                        button(for: .stepFontSize(points: 1))
+                        button(for: .stepFontSize(points: -1))
+                        button(for: .stepIndent(points: 1))
+                        button(for: .stepIndent(points: -1))
+                        button(for: .stepSuperscript(steps: 1))
+                        button(for: .stepSuperscript(steps: -1))
+                    }
+                    HStack {
+                        ForEach(RichTextStyle.allCases) {
+                            button(for: .toggleStyle($0))
+                        }
+                    }
+                }
+                .fixedSize(horizontal: false, vertical: true)
+                .padding()
+                .buttonStyle(.bordered)
             }
-            .fixedSize(horizontal: false, vertical: true)
-            .padding()
-            .buttonStyle(.bordered)
         }
     }
 

Sources/RichTextKit/Actions/RichTextAction.swift

@@ -15,7 +15,7 @@ import SwiftUI
  This type also serves as a type namespace for other related
  types and views, like ``RichTextAction/Button``.
  */
-public enum RichTextAction: Identifiable, Equatable {
+public enum RichTextAction: Identifiable, Equatable, RichTextLabelValue {
 
     /// Copy the currently selected text, if any.
     case copy

Sources/RichTextKit/Views/RichTextLabelValue.swift

@@ -26,7 +26,6 @@ public extension RichTextLabelValue {
             icon: { icon }
         )
         .tag(self)
-        .accessibilityLabel(title)
     }
 }