decode_json calls reflect::decode_json

Author: danielaparker

include/jsoncons/reflect/conv_result.hpp

@@ -47,6 +47,7 @@ class conv_result
     conv_result(std::error_code ec) noexcept
         : has_value_(false), ec_{ec}
     {
+        ::new (&ec_) std::error_code(ec);
     }
 
     // copy constructors
@@ -59,7 +60,7 @@ class conv_result
         }
         else
         {
-            ec_ = other.ec_;
+            ::new (&ec_) std::error_code(other.ec_);
         }
     }
 
@@ -73,7 +74,7 @@ class conv_result
         }
         else
         {
-            ec_ = other.ec_;
+            ::new (&ec_) std::error_code(other.ec_);
         }
     }
 
@@ -91,7 +92,7 @@ class conv_result
         else
         {
             destroy();
-            ec_ = other.ec_;
+            ::new (&ec_) std::error_code(other.ec_);
         }
         return *this;
     }
@@ -105,7 +106,7 @@ class conv_result
         else
         {
             destroy();
-            ec_ = other.ec_;
+            ::new (&ec_) std::error_code(other.ec_);
         }
         return *this;
     }

include/jsoncons/reflect/decode_traits.hpp

@@ -52,14 +52,15 @@ struct decode_traits
     {
         std::error_code ec;
 
-        auto j = try_to_json<basic_json<CharT>>(cursor, ec);
+        using json_type = basic_json<CharT>;
+        auto j = try_to_json<json_type>(cursor, ec);
         if (ec)
         {
             return result_type(read_error{ec, cursor.line(), cursor.column()});
         }
-        auto result = reflect::json_conv_traits<decltype(j), value_type>::try_as(j);
+        auto result = reflect::json_conv_traits<json_type, value_type>::try_as(j);
 
-        return result ? result_type{ { std::move(result.value()) } } : result_type{ {result.error(), cursor.line(), cursor.column()} };
+        return result ? result_type(std::move(result.value())) : result_type(read_error{result.error(), cursor.line(), cursor.column()});
     }
 };