Skip to content

Commit 36903e0

Browse files
committed
ci : update windows artifact uploads steps
This commit updates the windows job steps to use the built-in zip feature of the actions/upload-artifact action. This simplifies the jobs and also avoids the issue of zipping twice. This also modifies windows-blas which was updated previously but to now make the zip achive have an `Release` directory in it. Currently the files are all directly in the archive which I think might be surprising to most developers.
1 parent 450de07 commit 36903e0

File tree

1 file changed

+3
-13
lines changed

1 file changed

+3
-13
lines changed

.github/workflows/build.yml

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -604,19 +604,14 @@ jobs:
604604
name: ggml_cpu_${{ matrix.arch }}.dll
605605
path: build/bin/${{ matrix.build }}/ggml-cpu.dll
606606

607-
- name: Pack bin artifacts
608-
shell: pwsh
609-
run: |
610-
Compress-Archive -Path "build/bin/${{ matrix.build }}" -DestinationPath "whisper-bin-${{ matrix.arch }}.zip"
611-
612607
- name: Upload binaries
613608
if: matrix.sdl2 == 'ON' && ${{ (github.event_name == 'push' && github.ref == 'refs/heads/master') ||
614609
github.event.inputs.create_release == 'true' ||
615610
github.event.inputs.pre_release_tag != '' }}
616611
uses: actions/upload-artifact@v4
617612
with:
618613
name: whisper-bin-${{ matrix.arch }}.zip
619-
path: whisper-bin-${{ matrix.arch }}.zip
614+
path: "build/bin/${{ matrix.build }}"
620615

621616
windows-blas:
622617
if: ${{ github.event_name == 'push' || github.event_name == 'pull_request' ||
@@ -699,7 +694,7 @@ jobs:
699694
uses: actions/upload-artifact@v4
700695
with:
701696
name: whisper-blas-bin-${{ matrix.arch }}.zip
702-
path: "build/bin/${{ matrix.build }}/**"
697+
path: "build/bin/${{ matrix.build }}"
703698

704699
windows-cublas:
705700
if: ${{ github.event_name == 'push' || github.event_name == 'pull_request' ||
@@ -889,19 +884,14 @@ jobs:
889884
if: matrix.sdl2 == 'ON'
890885
run: copy "$env:SDL2_DIR/../lib/${{ matrix.arch }}/SDL2.dll" build/bin/${{ matrix.build }}
891886

892-
- name: Pack bin artifacts
893-
shell: pwsh
894-
run: |
895-
Compress-Archive -Path "build/bin/${{ matrix.build }}" -DestinationPath "whisper-cublas-${{ matrix.cuda-toolkit }}-bin-${{ matrix.arch }}.zip"
896-
897887
- name: Upload binaries
898888
if: ${{ (github.event_name == 'push' && github.ref == 'refs/heads/master') ||
899889
github.event.inputs.create_release == 'true' ||
900890
github.event.inputs.pre_release_tag != '' }}
901891
uses: actions/upload-artifact@v4
902892
with:
903893
name: whisper-cublas-${{ matrix.cuda-toolkit }}-bin-${{ matrix.arch }}.zip
904-
path: whisper-cublas-${{ matrix.cuda-toolkit }}-bin-${{ matrix.arch }}.zip
894+
path: "build/bin/${{ matrix.build }}"
905895

906896
emscripten:
907897
if: ${{ github.event_name == 'push' || github.event_name == 'pull_request' ||

0 commit comments

Comments
 (0)