Skip to content

Commit 1ef25d8

Browse files
committed
ci : zip windows artifacts for release uploading
This commit adds steps to the windows jobs to zip and upload artifacts produced. The motivation for this is that currently the artifacts are not zipped which means that will not be picked up by the release job and hence not be included in github releases.
1 parent 09846f4 commit 1ef25d8

File tree

1 file changed

+33
-8
lines changed

1 file changed

+33
-8
lines changed

.github/workflows/build.yml

Lines changed: 33 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -604,12 +604,19 @@ jobs:
604604
name: ggml_cpu_${{ matrix.arch }}.dll
605605
path: build/bin/${{ matrix.build }}/ggml-cpu.dll
606606

607+
- name: Pack bin artifacts
608+
shell: pwsh
609+
run: |
610+
Compress-Archive -Path "build/bin/${{ matrix.build }}" -DestinationPath "whisper-bin-${{ matrix.arch }}.zip"
611+
607612
- name: Upload binaries
608-
if: matrix.sdl2 == 'ON'
613+
if: matrix.sdl2 == 'ON' && ${{ (github.event_name == 'push' && github.ref == 'refs/heads/master') ||
614+
github.event.inputs.create_release == 'true' ||
615+
github.event.inputs.pre_release_tag != '' }}
609616
uses: actions/upload-artifact@v4
610617
with:
611-
name: whisper-bin-${{ matrix.arch }}
612-
path: build/bin/${{ matrix.build }}
618+
name: whisper-bin-${{ matrix.arch }}.zip
619+
path: whisper-bin-${{ matrix.arch }}.zip
613620

614621
windows-blas:
615622
if: ${{ github.event_name == 'push' || github.event_name == 'pull_request' ||
@@ -679,12 +686,19 @@ jobs:
679686
if: matrix.sdl2 == 'ON'
680687
run: copy "$env:SDL2_DIR/../lib/${{ matrix.s2arc }}/SDL2.dll" build/bin/${{ matrix.build }}
681688

689+
- name: Pack bin artifacts
690+
shell: pwsh
691+
run: |
692+
Compress-Archive -Path "build/bin/${{ matrix.build }}" -DestinationPath "whisper-blas-bin-${{ matrix.arch }}.zip"
693+
682694
- name: Upload binaries
683-
if: matrix.blas == 'ON' && matrix.sdl2 == 'ON'
695+
if: matrix.blas == 'ON' && matrix.sdl2 == 'ON' && ${{ (github.event_name == 'push' && github.ref == 'refs/heads/master') ||
696+
github.event.inputs.create_release == 'true' ||
697+
github.event.inputs.pre_release_tag != '' }}
684698
uses: actions/upload-artifact@v4
685699
with:
686-
name: whisper-blas-bin-${{ matrix.arch }}
687-
path: build/bin/${{ matrix.build }}
700+
name: whisper-blas-bin-${{ matrix.arch }}.zip
701+
path: whisper-blas-bin-${{ matrix.arch }}.zip
688702

689703
windows-cublas:
690704
if: ${{ github.event_name == 'push' || github.event_name == 'pull_request' ||
@@ -874,11 +888,19 @@ jobs:
874888
if: matrix.sdl2 == 'ON'
875889
run: copy "$env:SDL2_DIR/../lib/${{ matrix.arch }}/SDL2.dll" build/bin/${{ matrix.build }}
876890

891+
- name: Pack bin artifacts
892+
shell: pwsh
893+
run: |
894+
Compress-Archive -Path "build/bin/${{ matrix.build }}" -DestinationPath "whisper-cublas-${{ matrix.cuda-toolkit }}-bin-${{ matrix.arch }}.zip"
895+
877896
- name: Upload binaries
897+
if: ${{ (github.event_name == 'push' && github.ref == 'refs/heads/master') ||
898+
github.event.inputs.create_release == 'true' ||
899+
github.event.inputs.pre_release_tag != '' }}
878900
uses: actions/upload-artifact@v4
879901
with:
880-
name: whisper-cublas-${{ matrix.cuda-toolkit }}-bin-${{ matrix.arch }}
881-
path: build/bin/${{ matrix.build }}
902+
name: whisper-cublas-${{ matrix.cuda-toolkit }}-bin-${{ matrix.arch }}.zip
903+
path: whisper-cublas-${{ matrix.cuda-toolkit }}-bin-${{ matrix.arch }}.zip
882904

883905
emscripten:
884906
if: ${{ github.event_name == 'push' || github.event_name == 'pull_request' ||
@@ -1140,6 +1162,9 @@ jobs:
11401162
needs:
11411163
- determine-tag
11421164
- ios-xcode-build
1165+
- windows
1166+
- windows-blas
1167+
- windows-cublas
11431168

11441169
steps:
11451170
- name: Clone

0 commit comments

Comments
 (0)