[Feature] cover/contain based on landscape/portrait

[carlos22]

I have searched the existing feature requests to make sure this is not a duplicate request.

• Yes

The feature

Hi,

first of all, very cool project!I use it for an old android tablet that I framed which is really nice. Its always landscape so those pics fit best, but the thing is I don't want to miss out on the portrait ones. So it would be nice to have the possibility to set landscape ones to cover but portrait ones to contain. Its kind of working in the split view but I just want one pic at a time.

[damongolding]

I think the easiest way to accomplish this without adding more config options is to add the orientation of an image via a css class. That way you can use layout=single and image_fit=contain but then target landscape images with custom css

.frame--image-fit-contain.landscape {
  object-fit: cover;
}

[carlos22]

Yeah that sounds like a very good idea. Didn't think about custom css but this would provide all the options we need :)

[damongolding]

This will be available with the release of 0.21.0. The below setup will achieve this for you.

config

layout: single
image_fit: contain

custom.css

.frame--image--landscape {
    object-fit: cover;
}

[carlos22]

Just tried it and it works like a charm :) Thank you very much.