Skip to content

Commit dae5024

Browse files
committed
Refactor PaymentService to use handler by unique name
1 parent 4ec11bf commit dae5024

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/Http/Controllers/PaymentController.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,9 @@ public function sendToPaymentGateway(Request $request)
5959
}
6060

6161
/** @var PaymentHandlerInterface */
62-
$handler = app()->make(PaymentHandlerInterface::class);
62+
$basePaymentHandler = PaymentService::getHandlerFqcn($payment->payment_processor_name);
6363

64-
return $handler->proceedToPaymentGateway($payment, route('payment.finished.callback_url'), true);
64+
return $basePaymentHandler->proceedToPaymentGateway($payment, route('payment.finished.callback_url'), true);
6565
}
6666

6767
public function handlePaymentGatewayResponse(Request $request)

src/Services/PaymentService.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ public static function storePaymentAndShowUserBeforeProcessing(?int $user_id, fl
1919
return $basePaymentHandler->storePaymentAndShowUserBeforeProcessing($user_id, $amount, $description, $currency, $transaction_reference, null, null, $view, $metadata);
2020
}
2121

22-
private static function getHandlerFqcn(string $uniqueName): BasePaymentHandler
22+
public static function getHandlerFqcn(string $uniqueName): BasePaymentHandler
2323
{
24-
$handler = BasePaymentHandler::getNamesOfPaymentHandlers()->filter(fn($name) => $name === $uniqueName);
24+
$handler = BasePaymentHandler::getNamesOfPaymentHandlers()->filter(fn ($name) => $name === $uniqueName);
2525

2626
if ($handler->isEmpty()) {
2727
throw new \Exception("No handler found with name '{$uniqueName}'");
@@ -32,7 +32,7 @@ private static function getHandlerFqcn(string $uniqueName): BasePaymentHandler
3232
}
3333

3434
return $handler
35-
->map(fn($name, $key) => new $key)
35+
->map(fn ($name, $key) => new $key())
3636
->sole();
3737
}
3838

0 commit comments

Comments
 (0)