Add HasFactory trait to Payment model. Use app() instead of new. <commit message>

Author: damms005

src/Models/Payment.php

@@ -9,6 +9,7 @@
 use Illuminate\Database\Eloquent\Casts\AsArrayObject;
 use Damms005\LaravelMultipay\Contracts\PaymentHandlerInterface;
 use Damms005\LaravelMultipay\Services\PaymentHandlers\BasePaymentHandler;
+use Illuminate\Database\Eloquent\Factories\HasFactory;
 
 /**
  * @property int $id
@@ -38,6 +39,7 @@
 class Payment extends Model
 {
     use SoftDeletes;
+    use HasFactory;
 
     protected $guarded = ['id'];
 

src/Services/PaymentHandlers/BasePaymentHandler.php

@@ -234,7 +234,7 @@ public function reQueryUnsuccessfulPayment(Payment $unsuccessfulPayment): ?ReQue
         /** @var PaymentHandlerInterface **/
         $handler = new (PaymentService::getHandlerFqcn($unsuccessfulPayment->payment_processor_name));
 
-        $reQueryResponse = $handler->reQuery($unsuccessfulPayment);
+        $reQueryResponse = app(get_class($handler))->reQuery($unsuccessfulPayment);
 
         if ($reQueryResponse == null) {
             return null;

tests/PaymentRequeryTest.php

@@ -1,13 +1,14 @@
 <?php
 
 use Mockery\Mock;
+use Illuminate\Support\Str;
 use Illuminate\Support\Facades\Event;
 use Damms005\LaravelMultipay\Models\Payment;
+use Damms005\LaravelMultipay\ValueObjects\ReQuery;
 use Damms005\LaravelMultipay\Services\PaymentHandlers\Remita;
 use Damms005\LaravelMultipay\Contracts\PaymentHandlerInterface;
 use Damms005\LaravelMultipay\Services\PaymentHandlers\BasePaymentHandler;
 use Damms005\LaravelMultipay\Events\SuccessfulLaravelMultipayPaymentEvent;
-use Damms005\LaravelMultipay\ValueObjects\ReQuery;
 
 beforeEach(function () {
     $payment = createPayment();
@@ -40,18 +41,24 @@
         return $mock;
     });
 
-    app()->make(BasePaymentHandler::class)->reQueryUnsuccessfulPayment(new Payment());
+    app()->make(BasePaymentHandler::class)->reQueryUnsuccessfulPayment(
+        Payment::factory()->create(['payment_processor_name' => Remita::getUniquePaymentHandlerName()])
+    );
 });
 
 it('fires success events for re-query of successful payments', function () {
-    app()->bind(PaymentHandlerInterface::class, function () {
+    app()->bind(Remita::class, function () {
         /** @var Mock<TObject> */
         $mock = mock(Remita::class);
         $mock->makePartial();
 
         $mock->expects('reQuery')->andReturn(
             new ReQuery(
-                payment: new Payment(['is_success' => true]),
+                payment: Payment::factory()->create([
+                    'is_success' => true,
+                    'transaction_reference' => Str::random(),
+                    'payment_processor_name' => Remita::getUniquePaymentHandlerName(),
+                ]),
                 responseDetails: ['status' => 'Successful'],
             ),
         );
@@ -60,7 +67,12 @@
     });
 
     Event::fake();
-    app()->make(BasePaymentHandler::class)->reQueryUnsuccessfulPayment(new Payment());
+
+    app()
+        ->make(BasePaymentHandler::class)
+        ->reQueryUnsuccessfulPayment(
+            Payment::factory()->create(['payment_processor_name' => Remita::getUniquePaymentHandlerName()])
+        );
 
     Event::assertDispatched(SuccessfulLaravelMultipayPaymentEvent::class);
 });
@@ -85,7 +97,9 @@
 
     Event::fake();
 
-    app()->make(BasePaymentHandler::class)->reQueryUnsuccessfulPayment(new Payment());
+    app()->make(BasePaymentHandler::class)->reQueryUnsuccessfulPayment(
+        Payment::factory()->create(['payment_processor_name' => Remita::getUniquePaymentHandlerName()])
+    );
 
     Event::assertNotDispatched(SuccessfulLaravelMultipayPaymentEvent::class);
 });