Skip to content

Commit 3084d7a

Browse files
committed
fix: improved logging on Get()
1 parent 25278db commit 3084d7a

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

memcache4dalgo/get.go

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,19 +14,23 @@ func getRecord(
1414
get func(ctx context.Context, record dal.Record) error,
1515
) (err error) {
1616
key := record.Key()
17-
if !isCacheable(key) {
17+
if !isCacheable(key) { // If the record is not cacheable, we just get it from the database
1818
return get(ctx, record)
1919
}
2020
mk := key.String()
2121
var item *memcache.Item
2222
if item, err = memcache.Get(ctx, mk); err == nil {
23-
record.SetError(nil)
23+
record.SetError(nil) // We must indicate we are going to access data for unmarshalling
2424
if err = json.Unmarshal(item.Value, record.Data()); err == nil {
2525
if Debugf != nil {
2626
Debugf(ctx, "memcache4dalgo.getRecord: hit %s", mk)
2727
}
2828
return
29+
} else if Debugf != nil { // Ignore the error and try to get the record from the database
30+
Debugf(ctx, "memcache4dalgo.getRecord: failed to unmarshal value from received from memcache ny key=%s: %v", mk, err)
2931
}
32+
} else if Debugf != nil { // Ignore the error and try to get the record from the database
33+
Debugf(ctx, "memcache4dalgo.getRecord: memcache.Get(key=%s) returned error: %v", mk, err)
3034
}
3135
if err = get(ctx, record); err == nil {
3236
if err = setRecordToCache(ctx, record, "getRecord"); err != nil {
@@ -42,7 +46,7 @@ func setRecordToCache(ctx context.Context, record dal.Record, caller string) (er
4246
mk := record.Key().String()
4347
_ = memcache.Set(ctx, &memcache.Item{Value: value, Key: mk})
4448
if Debugf != nil {
45-
Debugf(ctx, "memcache4dalgo.%s: miss & set %s", caller, mk)
49+
Debugf(ctx, "memcache4dalgo.%s(): set record to cache with key=%s", caller, mk)
4650
}
4751
}
4852
return

0 commit comments

Comments
 (0)