Skip to content

cloud serverless deploy erroneously requires setup.py/requirements.txt in the dockerfile #29605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bmrickman opened this issue Apr 25, 2025 · 1 comment · May be fixed by #29571
Open

cloud serverless deploy erroneously requires setup.py/requirements.txt in the dockerfile #29605

bmrickman opened this issue Apr 25, 2025 · 1 comment · May be fixed by #29571
Labels
Dagster+ Relates to Dagster paid plans type: bug Something isn't working

Comments

@bmrickman
Copy link

What's the issue?

dagster-cloud serverless deploy is intended to allow users to deploy docker images to dagster cloud. Currently, the deployment checks for a setup.py/requirements.txt at the app root of the docker image. There's no reason for this, as it's not a pex deploy, and all dependencies should be maanged by the docker image. For my use case, this is a breaking bug.

Linking documentation discussion from before I realized this was a bug:
#29220

Linking the PR with the bugfix:
#29571

What did you expect to happen?

dagster-cloud serverless deploy should accept a docker image if it has the codeserver setup correctly.

How to reproduce?

Attepmt to run a docker serverless cloud deploy against any docker image that has the codeserver properly setup, but does not include a requirements.txt or setup.py

Dagster version

dagster, version 1.9.13

Deployment type

Dagster Cloud

Deployment details

No response

Additional information

I've tested and tagged the fix in a PR. I believe the setup.py/requirements.txt check was accidentally added to the docker deploy code.

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.

@bmrickman bmrickman added the type: bug Something isn't working label Apr 25, 2025
@garethbrickman garethbrickman added the Dagster+ Relates to Dagster paid plans label Apr 25, 2025
@bmrickman
Copy link
Author

bmrickman commented Apr 29, 2025

For those who run into this issue before its fixed:

To make things work with the current bug, you must include a setup.py or requirements.txt in the directory that you run the CLI tool from, and you must make sure the file doesn't end up in your docker image (by running something like RUN rm /app/setup.py in your Dockerfile).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dagster+ Relates to Dagster paid plans type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants