You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
dagster-cloud serverless deploy is intended to allow users to deploy docker images to dagster cloud. Currently, the deployment checks for a setup.py/requirements.txt at the app root of the docker image. There's no reason for this, as it's not a pex deploy, and all dependencies should be maanged by the docker image. For my use case, this is a breaking bug.
Linking documentation discussion from before I realized this was a bug: #29220
dagster-cloud serverless deploy should accept a docker image if it has the codeserver setup correctly.
How to reproduce?
Attepmt to run a docker serverless cloud deploy against any docker image that has the codeserver properly setup, but does not include a requirements.txt or setup.py
Dagster version
dagster, version 1.9.13
Deployment type
Dagster Cloud
Deployment details
No response
Additional information
I've tested and tagged the fix in a PR. I believe the setup.py/requirements.txt check was accidentally added to the docker deploy code.
Message from the maintainers
Impacted by this issue? Give it a 👍! We factor engagement into prioritization.
The text was updated successfully, but these errors were encountered:
For those who run into this issue before its fixed:
To make things work with the current bug, you must include a setup.py or requirements.txt in the directory that you run the CLI tool from, and you must make sure the file doesn't end up in your docker image (by running something like RUN rm /app/setup.py in your Dockerfile).
What's the issue?
dagster-cloud serverless deploy is intended to allow users to deploy docker images to dagster cloud. Currently, the deployment checks for a setup.py/requirements.txt at the app root of the docker image. There's no reason for this, as it's not a pex deploy, and all dependencies should be maanged by the docker image. For my use case, this is a breaking bug.
Linking documentation discussion from before I realized this was a bug:
#29220
Linking the PR with the bugfix:
#29571
What did you expect to happen?
dagster-cloud serverless deploy should accept a docker image if it has the codeserver setup correctly.
How to reproduce?
Attepmt to run a docker serverless cloud deploy against any docker image that has the codeserver properly setup, but does not include a requirements.txt or setup.py
Dagster version
dagster, version 1.9.13
Deployment type
Dagster Cloud
Deployment details
No response
Additional information
I've tested and tagged the fix in a PR. I believe the setup.py/requirements.txt check was accidentally added to the docker deploy code.
Message from the maintainers
Impacted by this issue? Give it a 👍! We factor engagement into prioritization.
The text was updated successfully, but these errors were encountered: