move startup helpers and constants to separate files

Author: daeh

.github/renovate.json

@@ -0,0 +1,21 @@
+{
+  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
+  "extends": [
+    "config:recommended",
+    ":semanticPrefixChore",
+    ":prHourlyLimitNone",
+    ":prConcurrentLimitNone",
+    ":enableVulnerabilityAlerts",
+    ":dependencyDashboard",
+    "schedule:weekends"
+  ],
+  "packageRules": [
+    {
+      "matchPackageNames": ["zotero-plugin-toolkit", "zotero-types"],
+      "automerge": true
+    }
+  ],
+  "git-submodules": {
+    "enabled": true
+  }
+}

.release-it.json

@@ -1,7 +1,12 @@
-[![GitHub release (latest by date)](https://img.shields.io/github/v/release/daeh/zotero-markdb-connect?style=for-the-badge)](https://github.com/daeh/zotero-markdb-connect/releases/latest) [![GitHub all releases](https://img.shields.io/github/downloads/daeh/zotero-markdb-connect/total?style=for-the-badge&color=forestgreen)](https://github.com/daeh/zotero-markdb-connect/releases/latest)
+[![GitHub release (with filter)](https://img.shields.io/github/v/release/daeh/zotero-markdb-connect?style=for-the-badge&filter=*v0.1.0*)](https://github.com/daeh/zotero-markdb-connect/releases/tag/v0.1.0-rc.3)
+
+<!-- [![GitHub release (latest by date)](https://img.shields.io/github/v/release/daeh/zotero-markdb-connect?style=for-the-badge)](https://github.com/daeh/zotero-markdb-connect/releases/latest) [![GitHub all releases](https://img.shields.io/github/downloads/daeh/zotero-markdb-connect/total?style=for-the-badge&color=forestgreen)](https://github.com/daeh/zotero-markdb-connect/releases/latest) -->
+
 
 # MarkDB-Connect (Zotero Markdown DataBase Connect)
 
+[![zotero target version](https://img.shields.io/badge/Zotero-7-green?style=flat-square&logo=zotero&logoColor=CC2936)](https://www.zotero.org) [![Using Zotero Plugin Template](https://img.shields.io/badge/Using-Zotero%20Plugin%20Template-blue?style=flat-square&logo=github)](https://github.com/windingwind/zotero-plugin-template)
+
 - **_Scans your Markdown database and adds a colored tag to associated Zotero items._**
 - **_Jump to Markdown notes from the contextual menu of Zotero items._**
 - **_Supports various Markdown databases, including [Obsidian](https://obsidian.md), [logseq](https://logseq.com), and [Zettlr](https://www.zettlr.com)_**
@@ -191,4 +196,4 @@ Distributed under the MIT License.
 
 ## Author
 
-[![Personal Website](https://img.shields.io/badge/personal%20website-daeh.info-orange?style=for-the-badge)](https://daeh.info) [![Blue Sky](https://img.shields.io/badge/bsky-@dae.bsky.social-skyblue?style=for-the-badge&logo=mastodon)](https://bsky.app/profile/dae.bsky.social) [![Twitter](https://img.shields.io/badge/twitter-@DaeHoulihan-blue?style=for-the-badge&logo=twitter)](https://twitter.com/DaeHoulihan)
+[![Personal Website](https://img.shields.io/badge/personal%20website-daeh.info-orange?style=for-the-badge)](https://daeh.info) [![BlueSky](https://img.shields.io/badge/bsky-@dae.bsky.social-skyblue?style=for-the-badge&logo=mastodon)](https://bsky.app/profile/dae.bsky.social) [![Twitter](https://img.shields.io/badge/twitter-@DaeHoulihan-white?style=for-the-badge&logo=twitter)](https://twitter.com/DaeHoulihan)

README.md

@@ -14,20 +14,20 @@ import globals from 'globals'
 
 const projectDirname = dirname(fileURLToPath(import.meta.url))
 
-const allTsExtensionsArray = ['ts', 'mts', 'cts', 'tsx', 'mtsx']
-const allJsExtensionsArray = ['js', 'mjs', 'cjs', 'jsx', 'mjsx']
-const allTsExtensions = allTsExtensionsArray.join(',')
-const allJsExtensions = allJsExtensionsArray.join(',')
-// @ts-expect-error - ignore this local variable
-const allExtensions = [...allTsExtensionsArray, ...allJsExtensionsArray].join(',')
-
 const env = (() => {
   if (typeof process.env.NODE_ENV === 'undefined') return 'base'
   if (process.env.NODE_ENV === 'development') return 'development'
   if (process.env.NODE_ENV === 'production') return 'production'
   return 'error'
 })()
 
+const allTsExtensionsArray = ['ts', 'mts', 'cts', 'tsx', 'mtsx']
+const allJsExtensionsArray = ['js', 'mjs', 'cjs', 'jsx', 'mjsx']
+const allTsExtensions = allTsExtensionsArray.join(',')
+const allJsExtensions = allJsExtensionsArray.join(',')
+// @ts-expect-error - ignore this local variable
+const allExtensions = [...allTsExtensionsArray, ...allJsExtensionsArray].join(',')
+
 const importRules = {
   'import/no-unresolved': 'error',
   'sort-imports': [
@@ -76,7 +76,20 @@ const baseRules = {
   // '@stylistic/multiline-ternary': ['warn', 'always'],
 }
 
-const typescriptRules = {}
+const typescriptRules = {
+  ...prettierConfig.rules,
+  ...pluginImportConfig.rules,
+  ...typescriptEslintPlugin.configs.recommended.rules,
+  ...typescriptEslintPlugin.configs['recommended-type-checked'].rules,
+  //
+  // ...typescriptEslintPlugin.configs.strict.rules,
+  // ...typescriptEslintPlugin.configs['strict-type-checked'].rules,
+  //
+  ...typescriptEslintPlugin.configs['stylistic-type-checked'].rules,
+  ...typescriptStylisticPlugin.configs['disable-legacy'].rules,
+  ...importRules,
+  ...baseRules,
+}
 
 const javascriptRules = {}
 
@@ -114,12 +127,12 @@ const config = [
     /* setup parser for all files */
     files: [`**/*.{${allTsExtensions}}`],
     languageOptions: {
-      sourceType: 'module',
       parser: typescriptEslintParser,
       parserOptions: {
         ecmaVersion: 'latest', // 2024 sets the ecmaVersion parser option to 15
         tsconfigRootDir: resolve(projectDirname),
         project: env === 'production' ? './tsconfig.prod.json' : './tsconfig.json',
+        sourceType: 'module',
       },
     },
   },
@@ -141,21 +154,22 @@ const config = [
       'prettier': prettierPlugin,
     },
     rules: {
-      ...prettierConfig.rules,
-      ...pluginImportConfig.rules,
-      ...typescriptEslintPlugin.configs.recommended.rules,
-      ...typescriptEslintPlugin.configs['recommended-type-checked'].rules,
-      //
-      // ...typescriptEslintPlugin.configs.strict.rules,
-      // ...typescriptEslintPlugin.configs['strict-type-checked'].rules,
-      //
-      ...typescriptEslintPlugin.configs['stylistic-type-checked'].rules,
-      ...typescriptStylisticPlugin.configs['disable-legacy'].rules,
-      ...importRules,
-      ...baseRules,
       ...typescriptRules,
     },
   },
+  {
+    /* +strict for typescript files NOT in ./src/ folder */
+    files: [`**/*.{${allTsExtensions}}`],
+    ignores: [`src/**/*.{${allTsExtensions}}`, `typing/**/*.d.ts`, `**/*.config.{${allTsExtensions}}`],
+    plugins: {
+      '@typescript-eslint': typescriptEslintPlugin,
+      '@stylistic': defaultStylisticPlugin,
+    },
+    rules: {
+      ...typescriptEslintPlugin.configs.strict.rules,
+      ...typescriptEslintPlugin.configs['strict-type-checked'].rules,
+    },
+  },
   {
     /* +lenient for typescript files in ./src/ folder */
     files: [`src/**/*.{${allTsExtensions}}`, `typing/**/*.d.ts`],
@@ -174,19 +188,6 @@ const config = [
       ...typescriptRulesDev,
     },
   },
-  {
-    /* +strict for typescript files NOT in ./src/ folder */
-    files: [`**/*.{${allTsExtensions}}`],
-    ignores: [`src/**/*.{${allTsExtensions}}`, `typing/**/*.d.ts`, `**/*.config.{${allTsExtensions}}`],
-    plugins: {
-      '@typescript-eslint': typescriptEslintPlugin,
-      '@stylistic': defaultStylisticPlugin,
-    },
-    rules: {
-      ...typescriptEslintPlugin.configs.strict.rules,
-      ...typescriptEslintPlugin.configs['strict-type-checked'].rules,
-    },
-  },
   {
     ignores: ['build', 'scripts', '**/*.js', '**/*.bak'],
   },

eslint.config.mjs

@@ -66,7 +66,7 @@
       "publish": false
     },
     "github": {
-      "release": false,
+      "release": true,
       "assets": [
         "build/*.xpi"
       ]

package.json

@@ -1,7 +1,7 @@
 {
   "usage": "Copy and rename this file to zotero-cmd.json. Edit the cmd.",
   "killZoteroWindows": "taskkill /f /im zotero.exe",
-  "killZoteroUnix": "kill -9 $(ps -x | grep zotero)",
+  "killZoteroUnix": "kill -9 $(ps -x | grep '[z]otero' | awk '{print $1}')", // DAEMOD
   "exec": {
     "@comment-zoteroBinPath": "Please input the path of the Zotero binary file in `zoteroBinPath`.",
     "@comment-zoteroBinPath-tip": "The path delimiter should be escaped as `\\` for win32. The path is `*/Zotero.app/Contents/MacOS/zotero` for MacOS.",

scripts/zotero-cmd-default.json

@@ -10,8 +10,8 @@ import {
   ScanMarkdownFiles,
   systemInterface,
   UIHelpers,
-  wrappers,
 } from './modules/mdbcScan'
+import { wrappers } from './modules/mdbcStartupHelpers'
 import { unpatch as $unpatch$ } from './modules/monkey-patch'
 import { registerPrefsScripts } from './modules/preferenceScript'
 import { getString, initLocale } from './utils/locale'

src/hooks.ts

@@ -0,0 +1,42 @@
+const _paramVals_filefilterstrategy = ['default', 'customfileregexp'] as const
+type _param_filefilterstrategy = (typeof _paramVals_filefilterstrategy)[number]
+
+const _paramVals_matchstrategy = ['bbtcitekeyyaml', 'bbtcitekeyregexp', 'zotitemkey'] as const
+type _paramTypes_matchstrategy = (typeof _paramVals_matchstrategy)[number]
+
+const _paramVals_mdeditor = ['system', 'obsidian', 'logseq'] as const
+type _param_mdeditor = (typeof _paramVals_mdeditor)[number]
+
+const _paramVals_obsidianresolvewithfile = [false, true] as const
+type _param_obsidianresolvewithfile = (typeof _paramVals_obsidianresolvewithfile)[number]
+const _paramVals_obsidianresolvespec = ['path', 'file'] as const
+type _param_obsidianresolvespec = (typeof _paramVals_obsidianresolvespec)[number]
+
+const _paramVals_grouplibraries = ['user', 'group'] as const
+type _param_grouplibraries = (typeof _paramVals_grouplibraries)[number]
+
+const _paramVals_removetags = ['keepsynced', 'addonly'] as const
+type _param_removetags = (typeof _paramVals_removetags)[number]
+
+const _paramVals_debugmode = ['minimal' as DebugMode, 'maximal' as DebugMode] as const
+
+export const paramVals = {
+  filefilterstrategy: _paramVals_filefilterstrategy,
+  matchstrategy: _paramVals_matchstrategy,
+  mdeditor: _paramVals_mdeditor,
+  obsidianresolvewithfile: _paramVals_obsidianresolvewithfile,
+  obsidianresolvespec: _paramVals_obsidianresolvespec,
+  grouplibraries: _paramVals_grouplibraries,
+  removetags: _paramVals_removetags,
+  debugmode: _paramVals_debugmode,
+}
+
+export declare interface paramTypes {
+  filefilterstrategy: _param_filefilterstrategy
+  matchstrategy: _paramTypes_matchstrategy
+  mdeditor: _param_mdeditor
+  obsidianresolvewithfile: _param_obsidianresolvewithfile
+  obsidianresolvespec: _param_obsidianresolvespec
+  grouplibraries: _param_grouplibraries
+  removetags: _param_removetags
+}