From 906b7c0703f2e39828a8854dff14a3057f6884c5 Mon Sep 17 00:00:00 2001 From: Ryan Manuel Date: Wed, 4 Jun 2025 07:18:49 -0500 Subject: [PATCH 1/3] internal: (studio) add indication in the console in local development that watch mode has detected a change --- packages/server/lib/cloud/studio/StudioLifecycleManager.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/packages/server/lib/cloud/studio/StudioLifecycleManager.ts b/packages/server/lib/cloud/studio/StudioLifecycleManager.ts index ed96964c6577..12b007852435 100644 --- a/packages/server/lib/cloud/studio/StudioLifecycleManager.ts +++ b/packages/server/lib/cloud/studio/StudioLifecycleManager.ts @@ -280,6 +280,11 @@ export class StudioLifecycleManager { return null }) + + await this.studioManagerPromise + + // eslint-disable-next-line no-console + console.log('Studio manager reloaded') }) } From 4f400df020873b85865bf6c3ef0f82b4df8b7475 Mon Sep 17 00:00:00 2001 From: Ryan Manuel Date: Wed, 4 Jun 2025 08:09:17 -0500 Subject: [PATCH 2/3] rework --- .../server/lib/cloud/studio/StudioLifecycleManager.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/server/lib/cloud/studio/StudioLifecycleManager.ts b/packages/server/lib/cloud/studio/StudioLifecycleManager.ts index 12b007852435..f58e9d817b11 100644 --- a/packages/server/lib/cloud/studio/StudioLifecycleManager.ts +++ b/packages/server/lib/cloud/studio/StudioLifecycleManager.ts @@ -275,16 +275,16 @@ export class StudioLifecycleManager { cloudDataSource, cfg, debugData, + }).then((studioManager) => { + // eslint-disable-next-line no-console + console.log('Studio manager reloaded') + + return studioManager }).catch((error) => { debug('Error during reload of studio manager: %o', error) return null }) - - await this.studioManagerPromise - - // eslint-disable-next-line no-console - console.log('Studio manager reloaded') }) } From b940c75909a128c1d2e3be109ff3b5793589df13 Mon Sep 17 00:00:00 2001 From: Ryan Manuel Date: Thu, 5 Jun 2025 16:46:07 -0500 Subject: [PATCH 3/3] PR comments --- packages/server/lib/cloud/studio/StudioLifecycleManager.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/server/lib/cloud/studio/StudioLifecycleManager.ts b/packages/server/lib/cloud/studio/StudioLifecycleManager.ts index f58e9d817b11..6f5f33d9dfcb 100644 --- a/packages/server/lib/cloud/studio/StudioLifecycleManager.ts +++ b/packages/server/lib/cloud/studio/StudioLifecycleManager.ts @@ -281,7 +281,8 @@ export class StudioLifecycleManager { return studioManager }).catch((error) => { - debug('Error during reload of studio manager: %o', error) + // eslint-disable-next-line no-console + console.error('Error during reload of studio manager: %o', error) return null })