From 5a33433f8eefbc60b8167b38922209aa60698174 Mon Sep 17 00:00:00 2001 From: Bill Glesias Date: Fri, 16 May 2025 10:17:53 -0400 Subject: [PATCH] chore: fix sinon-chai relative path rewrite as it is breaking type checking in the cypress cli externally --- .circleci/workflows.yml | 2 +- cli/scripts/post-install.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.circleci/workflows.yml b/.circleci/workflows.yml index a4051bb8a8e8..23f6ed888fd4 100644 --- a/.circleci/workflows.yml +++ b/.circleci/workflows.yml @@ -38,7 +38,7 @@ mainBuildFilters: &mainBuildFilters - /^release\/\d+\.\d+\.\d+$/ # use the following branch as well to ensure that v8 snapshot cache updates are fully tested - 'update-v8-snapshot-cache-on-develop' - - 'misc/throw_error_on_extension_chrome_137' + - 'misc/chore/fix_sinon_chai_rewrite' # usually we don't build Mac app - it takes a long time # but sometimes we want to really confirm we are doing the right thing diff --git a/cli/scripts/post-install.js b/cli/scripts/post-install.js index fdc4c6d947a5..b5da955439be 100644 --- a/cli/scripts/post-install.js +++ b/cli/scripts/post-install.js @@ -71,7 +71,7 @@ makeReferenceTypesCommentRelative('chai', '../chai/index.d.ts', sinonChaiFilenam makeReferenceTypesCommentRelative('sinon', '../sinon/index.d.ts', sinonChaiFilename) // and an import sinon line to be changed to relative path -shell.sed('-i', 'from \'sinon\';', 'from \'../sinon\';', sinonChaiFilename) +shell.sed('-i', 'from \"sinon\";', 'from \"../sinon\";', sinonChaiFilename) // copy experimental network stubbing type definitions // so users can import: `import 'cypress/types/net-stubbing'`