diff --git a/.circleci/workflows.yml b/.circleci/workflows.yml index b3d4a6388841..9fcb4348054e 100644 --- a/.circleci/workflows.yml +++ b/.circleci/workflows.yml @@ -38,7 +38,7 @@ mainBuildFilters: &mainBuildFilters - /^release\/\d+\.\d+\.\d+$/ # use the following branch as well to ensure that v8 snapshot cache updates are fully tested - 'update-v8-snapshot-cache-on-develop' - - 'fix/top_framebust_window_location' + - 'misc/chore/regen_snapshot_on_express_update' # usually we don't build Mac app - it takes a long time # but sometimes we want to really confirm we are doing the right thing @@ -49,7 +49,7 @@ macWorkflowFilters: &darwin-workflow-filters - equal: [ develop, << pipeline.git.branch >> ] # use the following branch as well to ensure that v8 snapshot cache updates are fully tested - equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ] - - equal: [ 'fix/top_framebust_window_location', << pipeline.git.branch >> ] + - equal: [ 'misc/chore/regen_snapshot_on_express_update', << pipeline.git.branch >> ] - matches: pattern: /^release\/\d+\.\d+\.\d+$/ value: << pipeline.git.branch >> @@ -60,7 +60,7 @@ linuxArm64WorkflowFilters: &linux-arm64-workflow-filters - equal: [ develop, << pipeline.git.branch >> ] # use the following branch as well to ensure that v8 snapshot cache updates are fully tested - equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ] - - equal: [ 'fix/top_framebust_window_location', << pipeline.git.branch >> ] + - equal: [ 'misc/chore/regen_snapshot_on_express_update', << pipeline.git.branch >> ] - matches: pattern: /^release\/\d+\.\d+\.\d+$/ value: << pipeline.git.branch >> @@ -83,7 +83,7 @@ windowsWorkflowFilters: &windows-workflow-filters - equal: [ develop, << pipeline.git.branch >> ] # use the following branch as well to ensure that v8 snapshot cache updates are fully tested - equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ] - - equal: [ 'fix/top_framebust_window_location', << pipeline.git.branch >> ] + - equal: [ 'misc/chore/regen_snapshot_on_express_update', << pipeline.git.branch >> ] - matches: pattern: /^release\/\d+\.\d+\.\d+$/ value: << pipeline.git.branch >> @@ -157,7 +157,7 @@ commands: name: Set environment variable to determine whether or not to persist artifacts command: | echo "Setting SHOULD_PERSIST_ARTIFACTS variable" - echo 'if ! [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "fix/top_framebust_window_location" ]]; then + echo 'if ! [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "misc/chore/regen_snapshot_on_express_update" ]]; then export SHOULD_PERSIST_ARTIFACTS=true fi' >> "$BASH_ENV" # You must run `setup_should_persist_artifacts` command and be using bash before running this command diff --git a/tooling/v8-snapshot/__snapshots__/express.spec.ts.js b/tooling/v8-snapshot/__snapshots__/express.spec.ts.js index afb652c8de7d..f4ac14c5d783 100644 --- a/tooling/v8-snapshot/__snapshots__/express.spec.ts.js +++ b/tooling/v8-snapshot/__snapshots__/express.spec.ts.js @@ -1,139 +1,139 @@ exports['integration: express installs snapshot for example-express 1'] = { - 'norewrite': [], - 'deferred': [ - './node_modules/body-parser/index.js', - './node_modules/debug/src/browser.js', - './node_modules/debug/src/index.js', - './node_modules/debug/src/node.js', - './node_modules/express/lib/application.js', - './node_modules/express/lib/request.js', - './node_modules/express/lib/response.js', - './node_modules/express/lib/router/index.js', - './node_modules/express/lib/router/route.js', - './node_modules/iconv-lite/encodings/dbcs-codec.js', - './node_modules/iconv-lite/encodings/index.js', - './node_modules/iconv-lite/encodings/internal.js', - './node_modules/iconv-lite/lib/index.js', - './node_modules/iconv-lite/lib/streams.js', - './node_modules/methods/index.js', - './node_modules/mime/mime.js', - './node_modules/object-inspect/index.js', - './node_modules/object-inspect/util.inspect.js', - './node_modules/safe-buffer/index.js', - './node_modules/safer-buffer/safer.js', - './node_modules/send/index.js', + "norewrite": [], + "deferred": [ + "./node_modules/body-parser/index.js", + "./node_modules/debug/src/browser.js", + "./node_modules/debug/src/index.js", + "./node_modules/debug/src/node.js", + "./node_modules/express/lib/application.js", + "./node_modules/express/lib/request.js", + "./node_modules/express/lib/response.js", + "./node_modules/express/lib/router/index.js", + "./node_modules/express/lib/router/route.js", + "./node_modules/iconv-lite/encodings/dbcs-codec.js", + "./node_modules/iconv-lite/encodings/index.js", + "./node_modules/iconv-lite/encodings/internal.js", + "./node_modules/iconv-lite/lib/index.js", + "./node_modules/iconv-lite/lib/streams.js", + "./node_modules/methods/index.js", + "./node_modules/mime/mime.js", + "./node_modules/object-inspect/index.js", + "./node_modules/object-inspect/util.inspect.js", + "./node_modules/safe-buffer/index.js", + "./node_modules/safer-buffer/safer.js", + "./node_modules/send/index.js" ], - 'healthy': [ - './node_modules/accepts/index.js', - './node_modules/accepts/node_modules/mime-db/db.json', - './node_modules/accepts/node_modules/mime-db/index.js', - './node_modules/accepts/node_modules/mime-types/index.js', - './node_modules/array-flatten/array-flatten.js', - './node_modules/body-parser/lib/read.js', - './node_modules/body-parser/lib/types/json.js', - './node_modules/body-parser/lib/types/raw.js', - './node_modules/body-parser/lib/types/text.js', - './node_modules/body-parser/lib/types/urlencoded.js', - './node_modules/body-parser/node_modules/content-type/index.js', - './node_modules/bytes/index.js', - './node_modules/call-bind/callBound.js', - './node_modules/call-bind/index.js', - './node_modules/content-disposition/index.js', - './node_modules/content-type/index.js', - './node_modules/cookie-signature/index.js', - './node_modules/cookie/index.js', - './node_modules/debug/src/debug.js', - './node_modules/define-data-property/index.js', - './node_modules/depd/index.js', - './node_modules/destroy/index.js', - './node_modules/ee-first/index.js', - './node_modules/encodeurl/index.js', - './node_modules/es-define-property/index.js', - './node_modules/es-errors/eval.js', - './node_modules/es-errors/index.js', - './node_modules/es-errors/range.js', - './node_modules/es-errors/ref.js', - './node_modules/es-errors/syntax.js', - './node_modules/es-errors/type.js', - './node_modules/es-errors/uri.js', - './node_modules/escape-html/index.js', - './node_modules/etag/index.js', - './node_modules/express/index.js', - './node_modules/express/lib/express.js', - './node_modules/express/lib/middleware/init.js', - './node_modules/express/lib/middleware/query.js', - './node_modules/express/lib/router/layer.js', - './node_modules/express/lib/utils.js', - './node_modules/express/lib/view.js', - './node_modules/finalhandler/index.js', - './node_modules/forwarded/index.js', - './node_modules/fresh/index.js', - './node_modules/function-bind/implementation.js', - './node_modules/function-bind/index.js', - './node_modules/get-intrinsic/index.js', - './node_modules/gopd/index.js', - './node_modules/has-property-descriptors/index.js', - './node_modules/has-proto/index.js', - './node_modules/has-symbols/index.js', - './node_modules/has-symbols/shams.js', - './node_modules/hasown/index.js', - './node_modules/http-errors/index.js', - './node_modules/iconv-lite/encodings/dbcs-data.js', - './node_modules/iconv-lite/encodings/sbcs-codec.js', - './node_modules/iconv-lite/encodings/sbcs-data-generated.js', - './node_modules/iconv-lite/encodings/sbcs-data.js', - './node_modules/iconv-lite/encodings/tables/big5-added.json', - './node_modules/iconv-lite/encodings/tables/cp936.json', - './node_modules/iconv-lite/encodings/tables/cp949.json', - './node_modules/iconv-lite/encodings/tables/cp950.json', - './node_modules/iconv-lite/encodings/tables/eucjp.json', - './node_modules/iconv-lite/encodings/tables/gb18030-ranges.json', - './node_modules/iconv-lite/encodings/tables/gbk-added.json', - './node_modules/iconv-lite/encodings/tables/shiftjis.json', - './node_modules/iconv-lite/encodings/utf16.js', - './node_modules/iconv-lite/encodings/utf7.js', - './node_modules/iconv-lite/lib/bom-handling.js', - './node_modules/iconv-lite/lib/extend-node.js', - './node_modules/inherits/inherits.js', - './node_modules/inherits/inherits_browser.js', - './node_modules/ipaddr.js/lib/ipaddr.js', - './node_modules/media-typer/index.js', - './node_modules/merge-descriptors/index.js', - './node_modules/mime-db/db.json', - './node_modules/mime-db/index.js', - './node_modules/mime-types/index.js', - './node_modules/mime/types.json', - './node_modules/ms/index.js', - './node_modules/negotiator/index.js', - './node_modules/negotiator/lib/charset.js', - './node_modules/negotiator/lib/encoding.js', - './node_modules/negotiator/lib/language.js', - './node_modules/negotiator/lib/mediaType.js', - './node_modules/on-finished/index.js', - './node_modules/parseurl/index.js', - './node_modules/path-to-regexp/index.js', - './node_modules/proxy-addr/index.js', - './node_modules/qs/lib/formats.js', - './node_modules/qs/lib/index.js', - './node_modules/qs/lib/parse.js', - './node_modules/qs/lib/stringify.js', - './node_modules/qs/lib/utils.js', - './node_modules/range-parser/index.js', - './node_modules/raw-body/index.js', - './node_modules/send/node_modules/encodeurl/index.js', - './node_modules/send/node_modules/ms/index.js', - './node_modules/serve-static/index.js', - './node_modules/set-function-length/index.js', - './node_modules/setprototypeof/index.js', - './node_modules/side-channel/index.js', - './node_modules/statuses/codes.json', - './node_modules/statuses/index.js', - './node_modules/toidentifier/index.js', - './node_modules/type-is/index.js', - './node_modules/unpipe/index.js', - './node_modules/utils-merge/index.js', - './node_modules/vary/index.js', - './snapshot/snapshot.js', + "healthy": [ + "./node_modules/accepts/index.js", + "./node_modules/accepts/node_modules/mime-db/db.json", + "./node_modules/accepts/node_modules/mime-db/index.js", + "./node_modules/accepts/node_modules/mime-types/index.js", + "./node_modules/array-flatten/array-flatten.js", + "./node_modules/body-parser/lib/read.js", + "./node_modules/body-parser/lib/types/json.js", + "./node_modules/body-parser/lib/types/raw.js", + "./node_modules/body-parser/lib/types/text.js", + "./node_modules/body-parser/lib/types/urlencoded.js", + "./node_modules/body-parser/node_modules/content-type/index.js", + "./node_modules/bytes/index.js", + "./node_modules/call-bind/callBound.js", + "./node_modules/call-bind/index.js", + "./node_modules/content-disposition/index.js", + "./node_modules/content-type/index.js", + "./node_modules/cookie-signature/index.js", + "./node_modules/cookie/index.js", + "./node_modules/debug/src/debug.js", + "./node_modules/define-data-property/index.js", + "./node_modules/depd/index.js", + "./node_modules/destroy/index.js", + "./node_modules/ee-first/index.js", + "./node_modules/encodeurl/index.js", + "./node_modules/es-define-property/index.js", + "./node_modules/es-errors/eval.js", + "./node_modules/es-errors/index.js", + "./node_modules/es-errors/range.js", + "./node_modules/es-errors/ref.js", + "./node_modules/es-errors/syntax.js", + "./node_modules/es-errors/type.js", + "./node_modules/es-errors/uri.js", + "./node_modules/escape-html/index.js", + "./node_modules/etag/index.js", + "./node_modules/express/index.js", + "./node_modules/express/lib/express.js", + "./node_modules/express/lib/middleware/init.js", + "./node_modules/express/lib/middleware/query.js", + "./node_modules/express/lib/router/layer.js", + "./node_modules/express/lib/utils.js", + "./node_modules/express/lib/view.js", + "./node_modules/finalhandler/index.js", + "./node_modules/forwarded/index.js", + "./node_modules/fresh/index.js", + "./node_modules/function-bind/implementation.js", + "./node_modules/function-bind/index.js", + "./node_modules/get-intrinsic/index.js", + "./node_modules/gopd/index.js", + "./node_modules/has-property-descriptors/index.js", + "./node_modules/has-proto/index.js", + "./node_modules/has-symbols/index.js", + "./node_modules/has-symbols/shams.js", + "./node_modules/hasown/index.js", + "./node_modules/http-errors/index.js", + "./node_modules/iconv-lite/encodings/dbcs-data.js", + "./node_modules/iconv-lite/encodings/sbcs-codec.js", + "./node_modules/iconv-lite/encodings/sbcs-data-generated.js", + "./node_modules/iconv-lite/encodings/sbcs-data.js", + "./node_modules/iconv-lite/encodings/tables/big5-added.json", + "./node_modules/iconv-lite/encodings/tables/cp936.json", + "./node_modules/iconv-lite/encodings/tables/cp949.json", + "./node_modules/iconv-lite/encodings/tables/cp950.json", + "./node_modules/iconv-lite/encodings/tables/eucjp.json", + "./node_modules/iconv-lite/encodings/tables/gb18030-ranges.json", + "./node_modules/iconv-lite/encodings/tables/gbk-added.json", + "./node_modules/iconv-lite/encodings/tables/shiftjis.json", + "./node_modules/iconv-lite/encodings/utf16.js", + "./node_modules/iconv-lite/encodings/utf7.js", + "./node_modules/iconv-lite/lib/bom-handling.js", + "./node_modules/iconv-lite/lib/extend-node.js", + "./node_modules/inherits/inherits.js", + "./node_modules/inherits/inherits_browser.js", + "./node_modules/ipaddr.js/lib/ipaddr.js", + "./node_modules/media-typer/index.js", + "./node_modules/merge-descriptors/index.js", + "./node_modules/mime-db/db.json", + "./node_modules/mime-db/index.js", + "./node_modules/mime-types/index.js", + "./node_modules/mime/types.json", + "./node_modules/ms/index.js", + "./node_modules/negotiator/index.js", + "./node_modules/negotiator/lib/charset.js", + "./node_modules/negotiator/lib/encoding.js", + "./node_modules/negotiator/lib/language.js", + "./node_modules/negotiator/lib/mediaType.js", + "./node_modules/on-finished/index.js", + "./node_modules/parseurl/index.js", + "./node_modules/path-to-regexp/index.js", + "./node_modules/proxy-addr/index.js", + "./node_modules/qs/lib/formats.js", + "./node_modules/qs/lib/index.js", + "./node_modules/qs/lib/parse.js", + "./node_modules/qs/lib/stringify.js", + "./node_modules/qs/lib/utils.js", + "./node_modules/range-parser/index.js", + "./node_modules/raw-body/index.js", + "./node_modules/send/node_modules/encodeurl/index.js", + "./node_modules/send/node_modules/ms/index.js", + "./node_modules/serve-static/index.js", + "./node_modules/set-function-length/index.js", + "./node_modules/setprototypeof/index.js", + "./node_modules/side-channel/index.js", + "./node_modules/statuses/codes.json", + "./node_modules/statuses/index.js", + "./node_modules/toidentifier/index.js", + "./node_modules/type-is/index.js", + "./node_modules/unpipe/index.js", + "./node_modules/utils-merge/index.js", + "./node_modules/vary/index.js", + "./snapshot/snapshot.js" ], - 'deferredHashFile': 'yarn.lock', + "deferredHashFile": "yarn.lock" }