Merge pull request #21 from Shadow243/refactoring-redirect-filter-action

josaphatim · web-flow · commit 3590d0fdb708 · 2024-08-03T16:54:15.000+02:00
Refactor if condition in parse function
diff --git a/src/Filters/Actions/RedirectFilterAction.php b/src/Filters/Actions/RedirectFilterAction.php
@@ -29,10 +29,8 @@ public function parse() {
             $this->require[] = 'copy';
             $script .= " :copy";
         }
-        if (isset($this->params['notify']) || isset($this->params['notify'])) {
-            $this->require[] = 'redirect-dsn';
-        }
         if (!empty($this->params['notify'])) {
+            $this->require[] = 'redirect-dsn';
             $script .= " :notify \"{$this->params['notify']}\"";
         }
         if (!empty($this->params['ret'])) {

Original file line number	Diff line number	Diff line change
`@@ -29,10 +29,8 @@ public function parse() {`
`29`	`29`	`$this->require[] = 'copy';`
`30`	`30`	`$script .= " :copy";`
`31`	`31`	`}`
`32`		`- if (isset($this->params['notify']) \|\| isset($this->params['notify'])) {`
`33`		`- $this->require[] = 'redirect-dsn';`
`34`		`- }`
`35`	`32`	`if (!empty($this->params['notify'])) {`
	`33`	`+ $this->require[] = 'redirect-dsn';`
`36`	`34`	`$script .= " :notify \"{$this->params['notify']}\"";`
`37`	`35`	`}`
`38`	`36`	`if (!empty($this->params['ret'])) {`