forbidden_modification error

[RobinHankin]

hi there, love the idea and thanks for the package! I'm having difficulty getting going. I have a repo and tried bump_version():

rhankin@limpet:~/rstudio/magic$ ls
data  DESCRIPTION  inst  man  NAMESPACE  NEWS.md  R  README.md  README.Rmd  revdep  tests  vignettes
rhankin@limpet:~/rstudio/magic$ R -q -e "fledge::bump_version()"
> fledge::bump_version()
Error in check_clean(c("DESCRIPTION", news_path)) : 
  !any(forbidden_modifications %in% status$file) is not TRUE
Calls: <Anonymous> -> check_clean -> stopifnot
Execution halted
rhankin@limpet:~/rstudio/magic$ 

This is related to #111 but I couldn't see how to proceed. Can you advise?

[krlmlr]

Thanks. This means that your Git working copy contains changes in files other than DESCRIPTION and NEWS.md . Double-check with git status .

We really need to show a clearer error message, and perhaps also document the condition when this error occurs.

[RobinHankin]

Thank you! That makes sense. But the forbidden change was that I created an empty NEWS.md file. But if I remove it I get:

rhankin@limpet:~/rstudio/magic$ git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
rhankin@limpet:~/rstudio/magic$ R -q -e "fledge::bump_version()"
> fledge::bump_version()
✔ Setting active project to '/home/rhankin/rstudio/magic'
→ Scraping 27 commit messages.
✔ Found 1 NEWS-worthy entries.

── Updating NEWS ──

→ Adding new entries to NEWS.md.

── Update Version ──

✔ Package version bumped to 1.6.0.9000.
→ Adding header to NEWS.md.
Error in file(con, "r") : cannot open the connection
Calls: <Anonymous> ... date_in_news_headers -> get_news_headers -> readLines -> file
In addition: Warning messages:
1: In readLines(con, warn = FALSE, n = n, ok = ok, skipNul = skipNul,  :
  cannot open file 'NEWS.md': No such file or directory
2: In value[[3L]](cond) : Cannot read NEWS.md: cannot open the connection
3: In file(path, "rb") :
  cannot open file 'NEWS.md': No such file or directory
4: When processing NEWS.md: subscript out of bounds 
5: In file(con, "r") :
  cannot open file 'NEWS.md': No such file or directory
Execution halted
rhankin@limpet:~/rstudio/magic$ 

so I get forbidden problems if it is there, and a different error if it is absent. How to get round this?

[krlmlr]

This is a bug, can you please file an issue?

To work around, please create an empty NEWS.md and commit it.

[RobinHankin]

thanks for this, I raised issue #150 just now on the work around. If I understand correctly, the issue is that if NEWS.md does not exist in the repo then things break?