Add status conditions for image prefetch progress and failure in controller

Signed-off-by: zeroalphat <taichi-takemura@cybozu.co.jp>

Author: zeroalphat

internal/controller/imageprefetch_controller.go

@@ -330,6 +330,18 @@ func (r *ImagePrefetchReconciler) updateStatus(ctx context.Context, imgPrefetch
 	logger := log.FromContext(ctx)
 	imgPrefetch.Status.ObservedGeneration = imgPrefetch.Generation
 	imgPrefetch.Status.SelectedNodes = selectedNodes
+	meta.SetStatusCondition(&imgPrefetch.Status.Conditions, metav1.Condition{
+		Type:    ofenv1.ConditionReady,
+		Status:  metav1.ConditionFalse,
+		Reason:  "ImagePrefetchProgressing",
+		Message: "Waiting for all nodes to pull the image",
+	})
+	meta.SetStatusCondition(&imgPrefetch.Status.Conditions, metav1.Condition{
+		Type:    ofenv1.ConditionImagePullFailed,
+		Status:  metav1.ConditionFalse,
+		Reason:  "ImagePrefetchFailed",
+		Message: "Waiting for all nodes to pull the image",
+	})
 	result := ctrl.Result{RequeueAfter: 10 * time.Second}
 
 	nodeImageSets := &ofenv1.NodeImageSetList{}

internal/controller/imageprefetch_controller_test.go

@@ -227,43 +227,87 @@ var _ = Describe("ImagePrefetch Controller", func() {
 				g.Expect(err).NotTo(HaveOccurred())
 
 				conditionImagePrefetchReady := meta.FindStatusCondition(imagePrefetch.Status.Conditions, ofenv1.ConditionReady)
-				g.Expect(conditionImagePrefetchReady).To(BeNil())
+				g.Expect(conditionImagePrefetchReady).NotTo(BeNil())
+				g.Expect(conditionImagePrefetchReady.Status).To(Equal(metav1.ConditionFalse))
 				conditionImagePrefetchProcessing := meta.FindStatusCondition(imagePrefetch.Status.Conditions, ofenv1.ConditionProgressing)
 				g.Expect(conditionImagePrefetchProcessing).NotTo(BeNil())
 				g.Expect(conditionImagePrefetchProcessing.Status).To(Equal(metav1.ConditionTrue))
 				conditionImagePrefetchFailed := meta.FindStatusCondition(imagePrefetch.Status.Conditions, ofenv1.ConditionImagePullFailed)
-				g.Expect(conditionImagePrefetchFailed).To(BeNil())
+				g.Expect(conditionImagePrefetchFailed).NotTo(BeNil())
+				g.Expect(conditionImagePrefetchFailed.Status).To(Equal(metav1.ConditionFalse))
 			}).Should(Succeed())
 
-			By("updating nodeImageSet's status to image available")
-			nodeImageSets := &ofenv1.NodeImageSetList{}
-			err := k8sClient.List(ctx, nodeImageSets, &client.ListOptions{
-				LabelSelector: labels.SelectorFromSet(map[string]string{
-					constants.OwnerImagePrefetchNamespace: testName,
-				}),
-			})
-			Expect(err).NotTo(HaveOccurred())
+			By("updating nodeImageSet's status to image pull failed")
+			failedCondition := metav1.Condition{
+				Type:               ofenv1.ConditionImageDownloadFailed,
+				Reason:             "test",
+				Status:             metav1.ConditionTrue,
+				LastTransitionTime: metav1.Now(),
+			}
+			Eventually(func(g Gomega) {
+				nodeImageSets := &ofenv1.NodeImageSetList{}
+				err := k8sClient.List(ctx, nodeImageSets, &client.ListOptions{
+					LabelSelector: labels.SelectorFromSet(map[string]string{
+						constants.OwnerImagePrefetchNamespace: testName,
+					}),
+				})
+				g.Expect(err).NotTo(HaveOccurred())
 
-			now := metav1.Now()
-			for _, nodeImageSet := range nodeImageSets.Items {
-				nodeImageSet.Status.Conditions = []metav1.Condition{
-					{
-						Type:               ofenv1.ConditionImageAvailable,
-						Reason:             "test",
-						Status:             metav1.ConditionTrue,
-						LastTransitionTime: now,
-					},
-					{
-						Type:               ofenv1.ConditionImageDownloadComplete,
-						Reason:             "test",
-						Status:             metav1.ConditionTrue,
-						LastTransitionTime: now,
-					},
+				for _, nodeImageSet := range nodeImageSets.Items {
+					nodeImageSet.Status.Conditions = []metav1.Condition{failedCondition}
+					err = k8sClient.Status().Update(ctx, &nodeImageSet)
+					g.Expect(err).NotTo(HaveOccurred())
 				}
+			}).Should(Succeed())
+
+			By("checking imagePrefetch status to be failed")
+			Eventually(func(g Gomega) {
+				imagePrefetch := &ofenv1.ImagePrefetch{}
+				err := k8sClient.Get(ctx, client.ObjectKey{Name: testName, Namespace: testName}, imagePrefetch)
+				g.Expect(err).NotTo(HaveOccurred())
 
-				err = k8sClient.Status().Update(ctx, &nodeImageSet)
-				Expect(err).NotTo(HaveOccurred())
+				conditionImagePrefetchReady := meta.FindStatusCondition(imagePrefetch.Status.Conditions, ofenv1.ConditionReady)
+				g.Expect(conditionImagePrefetchReady).NotTo(BeNil())
+				g.Expect(conditionImagePrefetchReady.Status).To(Equal(metav1.ConditionFalse))
+				conditionImagePrefetchProcessing := meta.FindStatusCondition(imagePrefetch.Status.Conditions, ofenv1.ConditionProgressing)
+				g.Expect(conditionImagePrefetchProcessing).NotTo(BeNil())
+				g.Expect(conditionImagePrefetchProcessing.Status).To(Equal(metav1.ConditionTrue))
+				conditionImagePrefetchFailed := meta.FindStatusCondition(imagePrefetch.Status.Conditions, ofenv1.ConditionImagePullFailed)
+				g.Expect(conditionImagePrefetchFailed).NotTo(BeNil())
+				g.Expect(conditionImagePrefetchFailed.Status).To(Equal(metav1.ConditionTrue))
+			}).Should(Succeed())
+
+			By("updating nodeImageSet's status to image available")
+			failedCondition.Status = metav1.ConditionFalse
+			imageAvailableCondition := metav1.Condition{
+				Type:               ofenv1.ConditionImageAvailable,
+				Reason:             "test",
+				Status:             metav1.ConditionTrue,
+				LastTransitionTime: metav1.Now(),
 			}
+			imageDownloadCompleteCondition := metav1.Condition{
+				Type:               ofenv1.ConditionImageDownloadComplete,
+				Reason:             "test",
+				Status:             metav1.ConditionTrue,
+				LastTransitionTime: metav1.Now(),
+			}
+
+			Eventually(func(g Gomega) {
+				nodeImageSets := &ofenv1.NodeImageSetList{}
+				err := k8sClient.List(ctx, nodeImageSets, &client.ListOptions{
+					LabelSelector: labels.SelectorFromSet(map[string]string{
+						constants.OwnerImagePrefetchNamespace: testName,
+					}),
+				})
+				g.Expect(err).NotTo(HaveOccurred())
+
+				for _, nodeImageSet := range nodeImageSets.Items {
+					nodeImageSet.Status.Conditions = []metav1.Condition{
+						failedCondition, imageAvailableCondition, imageDownloadCompleteCondition}
+					err = k8sClient.Status().Update(ctx, &nodeImageSet)
+					Expect(err).NotTo(HaveOccurred())
+				}
+			}).Should(Succeed())
 
 			By("checking imagePrefetch status to be ready")
 			Eventually(func(g Gomega) {
@@ -279,8 +323,8 @@ var _ = Describe("ImagePrefetch Controller", func() {
 				g.Expect(conditionImagePrefetchProcessing).NotTo(BeNil())
 				g.Expect(conditionImagePrefetchProcessing.Status).To(Equal(metav1.ConditionTrue))
 				conditionImagePrefetchFailed := meta.FindStatusCondition(imagePrefetch.Status.Conditions, ofenv1.ConditionImagePullFailed)
-				g.Expect(conditionImagePrefetchFailed).To(BeNil())
-
+				g.Expect(conditionImagePrefetchFailed).NotTo(BeNil())
+				g.Expect(conditionImagePrefetchFailed.Status).To(Equal(metav1.ConditionFalse))
 			}).Should(Succeed())
 		})