Reflect a review

terassyi · terassyi · commit f7f4141b0c96 · 2025-05-30T08:19:34.000Z
Signed-off-by: terashima &lt;tomoya-terashima@cybozu.co.jp&gt;
diff --git a/v2/pkg/founat/egress.go b/v2/pkg/founat/egress.go
@@ -76,8 +76,7 @@ func (e *egress) Init() error {
 		if err != nil {
 			return fmt.Errorf("failed to setup masquerade rule for IPv4: %w", err)
 		}
-		err = ipt.Append("filter", "FORWARD", "-o", e.iface, "-m", "state", "--state", "INVALID", "-j", "DROP")
-		if err != nil {
+		if err := ipt.Append("filter", "FORWARD", "-o", e.iface, "-m", "state", "--state", "INVALID", "-j", "DROP"); err != nil {
 			return fmt.Errorf("failed to setup drop rule for invalid packets: %w", err)
 		}
 
@@ -96,8 +95,7 @@ func (e *egress) Init() error {
 		if err != nil {
 			return fmt.Errorf("failed to setup masquerade rule for IPv6: %w", err)
 		}
-		err = ipt.Append("filter", "FORWARD", "-o", e.iface, "-m", "state", "--state", "INVALID", "-j", "DROP")
-		if err != nil {
+		if err := ipt.Append("filter", "FORWARD", "-o", e.iface, "-m", "state", "--state", "INVALID", "-j", "DROP"); err != nil {
 			return fmt.Errorf("failed to setup drop rule for invalid packets: %w", err)
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -76,8 +76,7 @@ func (e *egress) Init() error {`
`76`	`76`	`if err != nil {`
`77`	`77`	`return fmt.Errorf("failed to setup masquerade rule for IPv4: %w", err)`
`78`	`78`	`}`
`79`		`- err = ipt.Append("filter", "FORWARD", "-o", e.iface, "-m", "state", "--state", "INVALID", "-j", "DROP")`
`80`		`- if err != nil {`
	`79`	`+ if err := ipt.Append("filter", "FORWARD", "-o", e.iface, "-m", "state", "--state", "INVALID", "-j", "DROP"); err != nil {`
`81`	`80`	`return fmt.Errorf("failed to setup drop rule for invalid packets: %w", err)`
`82`	`81`	`}`
`83`	`82`
`@@ -96,8 +95,7 @@ func (e *egress) Init() error {`
`96`	`95`	`if err != nil {`
`97`	`96`	`return fmt.Errorf("failed to setup masquerade rule for IPv6: %w", err)`
`98`	`97`	`}`
`99`		`- err = ipt.Append("filter", "FORWARD", "-o", e.iface, "-m", "state", "--state", "INVALID", "-j", "DROP")`
`100`		`- if err != nil {`
	`98`	`+ if err := ipt.Append("filter", "FORWARD", "-o", e.iface, "-m", "state", "--state", "INVALID", "-j", "DROP"); err != nil {`
`101`	`99`	`return fmt.Errorf("failed to setup drop rule for invalid packets: %w", err)`
`102`	`100`	`}`
`103`	`101`