Skip to content

Commit 6e0ead7

Browse files
authored
Merge pull request #59 from cybozu-go/rename-name-label
Update to use app.kubernetes.io/name
2 parents 7bc641c + 95691e7 commit 6e0ead7

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

mtest/controller.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ func TestCoilController() {
3838
Expect(err).NotTo(HaveOccurred(), "stderr: %s", stderr)
3939

4040
Eventually(func() error {
41-
stdout, stderr, err := kubectl("get", "pods", "--selector=run=nginx", "-o=json")
41+
stdout, stderr, err := kubectl("get", "pods", "--selector=app.kubernetes.io/name=nginx", "-o=json")
4242
if err != nil {
4343
return fmt.Errorf("%v: stderr=%s", err, stderr)
4444
}
@@ -87,7 +87,7 @@ func TestCoilController() {
8787
Expect(err).NotTo(HaveOccurred(), "stderr: %s", stderr)
8888

8989
Eventually(func() error {
90-
stdout, stderr, err := kubectl("get", "pods", "--selector=run=nginx", "-o=json")
90+
stdout, stderr, err := kubectl("get", "pods", "--selector=app.kubernetes.io/name=nginx", "-o=json")
9191
if err != nil {
9292
return fmt.Errorf("%v: stderr=%s", err, stderr)
9393
}
@@ -109,7 +109,7 @@ func TestCoilController() {
109109
Expect(err).NotTo(HaveOccurred(), "stderr: %s", stderr)
110110

111111
Eventually(func() error {
112-
stdout, stderr, err := kubectl("get", "deployment", "--selector=k8s-app=coil-controllers", "--namespace=kube-system", "-o=json")
112+
stdout, stderr, err := kubectl("get", "deployment", "--selector=app.kubernetes.io/name=coil-controllers", "--namespace=kube-system", "-o=json")
113113
if err != nil {
114114
return fmt.Errorf("%v: stderr=%s", err, stderr)
115115
}

mtest/deploy.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -106,19 +106,19 @@ metadata:
106106
name: coil-node
107107
namespace: kube-system
108108
labels:
109-
k8s-app: coil-node
109+
app.kubernetes.io/name: coil-node
110110
spec:
111111
selector:
112112
matchLabels:
113-
k8s-app: coil-node
113+
app.kubernetes.io/name: coil-node
114114
updateStrategy:
115115
type: RollingUpdate
116116
rollingUpdate:
117117
maxUnavailable: 1
118118
template:
119119
metadata:
120120
labels:
121-
k8s-app: coil-node
121+
app.kubernetes.io/name: coil-node
122122
spec:
123123
priorityClassName: system-node-critical
124124
nodeSelector:
@@ -220,21 +220,21 @@ metadata:
220220
name: coil-controllers
221221
namespace: kube-system
222222
labels:
223-
k8s-app: coil-controllers
223+
app.kubernetes.io/name: coil-controllers
224224
spec:
225225
# coil-controller can only have a single active instance.
226226
replicas: 1
227227
selector:
228228
matchLabels:
229-
k8s-app: coil-controllers
229+
app.kubernetes.io/name: coil-controllers
230230
strategy:
231231
type: Recreate
232232
template:
233233
metadata:
234234
name: coil-controllers
235235
namespace: kube-system
236236
labels:
237-
k8s-app: coil-controllers
237+
app.kubernetes.io/name: coil-controllers
238238
spec:
239239
priorityClassName: system-cluster-critical
240240
nodeSelector:

mtest/pod.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ func TestPod() {
285285
}
286286

287287
if pod.Status.Phase != corev1.PodRunning {
288-
return errors.New("pod is not Running")
288+
return fmt.Errorf("pod is not Running: %v", pod)
289289
}
290290
if len(pod.Status.PodIP) == 0 {
291291
return errors.New("pod is not assigned IP")

0 commit comments

Comments
 (0)