Patroni members extraction from consul

[ch3sh1re]

Hello!

As described in documentation, Consul support is implemented:
https://pgwat.ch/latest/tutorial/preparing_databases.html?h=consul#patroni

I also found a previous topic where it says Consul support is already implemented:
#60

However, function getConsulClusterMembers only returns nil in current release:
https://github.com/cybertec-postgresql/pgwatch/blob/v3.2.0/internal/sources/resolver.go#L66

I see that consul discovery is indeed implemented in pgwatch2:
https://github.com/cybertec-postgresql/pgwatch2/blob/master/pgwatch2/patroni.go#L31

Do you plan to support consul in new pgwatch?
Just in case I have fix for scope discovery which almost is copy-paste from pgwatch2 source, but I also added namespace clusters discovery (similar to etcd extraction): #729

Thank you.

[pashagolub]

Hi.

Yeah, I thought about deprecating consul support (and etcd) and switch to Patroni REST API discovery. Do you have access to Patroni REST API?

[ch3sh1re]

Sounds logical. But what about multi cluster patroni setup? For example right now we have an option (at least for etcd) to use namespace-discovery without mentioning all clusters in pgwatch config. But with patroni rest api we probably can't go same simple way.

[pashagolub]

Good question