Skip to content

Commit 327f335

Browse files
committed
Minor changes to for use of libs in script resolution (for consistency, should not matter in practice)
1 parent e627c7c commit 327f335

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/lang/php/analysis/includes/ScriptResolve.rsc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ public IncludeGraphNode decorateNode(IncludeGraphNode n, map[loc,set[ConstItemEx
7070
}
7171
}
7272

73-
public tuple[rel[loc,loc] resolved, lrel[str,datetime] timings] scriptResolve(System sys, str p, str v, loc toResolve, loc baseLoc, list[str] ipath=[], map[loc,rel[loc,Expr,loc]] quickResolveInfo = ( )) {
73+
public tuple[rel[loc,loc] resolved, lrel[str,datetime] timings] scriptResolve(System sys, str p, str v, loc toResolve, loc baseLoc, set[loc] libs = { }, list[str] ipath=[], map[loc,rel[loc,Expr,loc]] quickResolveInfo = ( )) {
7474
lrel[str,datetime] timings = [ < "Starting includes resolution", now() > ];
7575
clearLookupCache();
7676

@@ -84,7 +84,7 @@ public tuple[rel[loc,loc] resolved, lrel[str,datetime] timings] scriptResolve(Sy
8484
// and perform simplifications
8585
IncludesInfo iinfo = loadIncludesInfo(p, v);
8686
timings += < "Includes info loaded", now()>;
87-
quickResolved = (size(quickResolveInfo) > 0) ? ( (toResolve in quickResolveInfo) ? quickResolveInfo[toResolve] : { }) : quickResolveExpr(sys, iinfo, toResolve, baseLoc);
87+
quickResolved = (size(quickResolveInfo) > 0) ? ( (toResolve in quickResolveInfo) ? quickResolveInfo[toResolve] : { }) : quickResolveExpr(sys, iinfo, toResolve, baseLoc, libs=libs);
8888
timings += < "Finished with initial quick resolve", now()>;
8989
9090
// This gives us a base model of what can be immediately included
@@ -98,7 +98,7 @@ public tuple[rel[loc,loc] resolved, lrel[str,datetime] timings] scriptResolve(Sy
9898
while (! isEmpty(worklist) ) {
9999
next = getOneFrom(worklist); worklist -= next; worked += next;
100100
includeMap += ( i@at : i | /i:include(_,_) := sys[next] );
101-
nextResolved = (size(quickResolveInfo) > 0) ? ( (next in quickResolveInfo) ? quickResolveInfo[next] : { } ) : quickResolveExpr(sys, iinfo, next, baseLoc);
101+
nextResolved = (size(quickResolveInfo) > 0) ? ( (next in quickResolveInfo) ? quickResolveInfo[next] : { } ) : quickResolveExpr(sys, iinfo, next, baseLoc, libs=libs);
102102
quickResolved += nextResolved;
103103
worklist += ({ qri | qri <- nextResolved<2>, qri.scheme != "php+lib" } - worked);
104104
worked += { qri | qri <- nextResolved<2>, qri.scheme == "php+lib" };

src/lang/php/experiments/ase2014/ASE2014.rsc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ public void doQuickResolve(Corpus corpus) {
103103
counter = 0;
104104
for (l <- pt) {
105105
dt1 = now();
106-
qr = quickResolve(pt, iinfo, l, getCorpusItem(p,v) libs = (p in usedLibs) ? usedLibs[p] : { });
106+
qr = quickResolve(pt, iinfo, l, getCorpusItem(p,v), libs = (p in usedLibs) ? usedLibs[p] : { });
107107
dt2 = now();
108108
res = res + { < l, ll, lr > | < ll, lr > <- qr };
109109
counter += 1;
@@ -126,7 +126,7 @@ public void doQuickResolveExpr(Corpus corpus) {
126126
println("Resolving <p> for <size(pt<0>)> files");
127127
counter = 0;
128128
for (l <- pt) {
129-
qr = quickResolveExpr(pt, iinfo, l, getCorpusItem(p,v) libs = (p in usedLibs) ? usedLibs[p] : { });
129+
qr = quickResolveExpr(pt, iinfo, l, getCorpusItem(p,v), libs = (p in usedLibs) ? usedLibs[p] : { });
130130
res = res + { < l, ll, e, lr > | < ll, e, lr > <- qr };
131131
counter += 1;
132132
if (counter % 100 == 0) {
@@ -295,7 +295,7 @@ public void buildResolveInfo(Corpus corpus, str p, set[loc] files) {
295295
}
296296
for (f <- files) {
297297
println("Resolving script <f>");
298-
res = scriptResolve(pt, p, corpus[p], f, rootloc, ipath=getIncludePath(p), quickResolveInfo=qrmap);
298+
res = scriptResolve(pt, p, corpus[p], f, rootloc, libs = (p in usedLibs) ? usedLibs[p] : { }, ipath=getIncludePath(p), quickResolveInfo=qrmap);
299299
ResolveInfo ri = rinfo(p, corpus[p], f, res);
300300
lipath = incLoc + "ri<rmap.nextidx>.bin";
301301
writeBinaryValueFile(lipath, ri);

0 commit comments

Comments
 (0)