generated messages implement a trait

[poborin]

I recon Rust generated messages should implement traits to make them generic:

pub trait SendSignalToDart {
    fn send_signal_to_dart(&self);
}

pub trait GetDartSignalReceiver {
    pub fn get_dart_signal_receiver() -> SignalReceiver<DartSignal<Self>>;
}

or something along these lines.

[temeddix]

That's a good point. It would definitely be possible to implement the trait like that. May I ask you the actual use case for that?

[poborin]

I'm currently working with the suggested Report trait. If T implements a SendSignalToDart it simplifies the reporting. I haven't found a use case for the GetDartSignalReceiver yet.

as an example, the report implementation may look something like that then:

impl<T> Report<T> for Result<T, Error>
where
    T: SendSignalToDart,
{
    fn report(self) {
        match self {
            Ok(value) => {
                value.send_signal_to_dart();
            }
            Err(err) => {
                // Handle the error case
            }
        }
    }
}

[temeddix]

It looks like you're trying to implement Report for multiple message types. However what I've tried to suggest is closer to something like below - A top-level function reporting the propagated error:

use std::fmt::Debug;
use anyhow::Error;

pub trait Report<(), E: Debug> {
    fn report(self);
}

impl Report for Result<(), Error>
{
    fn report(self) {
        match self {
            Ok(value) => (),
            Err(err) => {
                // Handle the error case
                // by sending a message `ErrorNotify` to Dart,
                ErrorNotify {
                    message: format!("Rust error {:?}", err);
                    error_code: 25,
                }
                .send_signal_to_dart()
            }
        }
    }
}

async fn do_work () -> Result<(), Error> {
    let my_response = make_http_request().await?;
    // Do something with `my_response`
    // There might be more code below
}

async fn parent_work () {
    let result = do_work().await;
    result.report();
}

I don't see where implementing that Report trait for multiple message types would be helpful yet. If I've missed something, please let me know :)

[poborin]

I see what you are saying. I'm currently experimenting with different options trying to find a solution for my problem.

[temeddix]

This is now implemented in Rinf version 8