Skip to content

Commit ace3df0

Browse files
committed
Add failure handling for list creatoin
1 parent 28e84ee commit ace3df0

File tree

7 files changed

+11
-2
lines changed

7 files changed

+11
-2
lines changed

app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ android {
66
applicationId "com.quchen.flashcard"
77
minSdkVersion 21
88
targetSdkVersion 34
9-
versionCode 23
10-
versionName "v1.7.0"
9+
versionCode 24
10+
versionName "v1.7.1"
1111
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
1212
}
1313
buildTypes {

app/release/app-release.aab

-6.69 KB
Binary file not shown.

app/release/app-release.apk

-3.27 MB
Binary file not shown.

app/src/main/java/com/quchen/flashcard/ListActivity.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -222,6 +222,12 @@ private void showListAdd() {
222222
final String rightVal = rightEdit.getText().toString();
223223
final String titleVal = listNameEdit.getText().toString();
224224

225+
if(leftVal.isEmpty() || rightVal.isEmpty() || titleVal.isEmpty())
226+
{
227+
Toast.makeText(ListActivity.this, R.string.addListError, Toast.LENGTH_SHORT).show();
228+
return;
229+
}
230+
225231
ListItem listItem = new ListItem(String.format("%s/%s.csv", folderName, titleVal), leftVal, rightVal);
226232
listItem.saveToFile();
227233

app/src/main/java/com/quchen/flashcard/ListViewActivity.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@ private void showItemEditDialog(ListItem.ItemPair itemPair) {
106106
final String leftVal = leftEdit.getText().toString();
107107
final String rightVal = rightEdit.getText().toString();
108108
if(leftVal.isEmpty() || rightVal.isEmpty()){
109+
Toast.makeText(ListViewActivity.this, R.string.addListError, Toast.LENGTH_SHORT).show();
109110
return;
110111
}
111112

app/src/main/res/values-de/strings.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,5 @@
4444
<string name="listName">Listen Name</string>
4545
<string name="leftColumn">Linke Spalte</string>
4646
<string name="RightColumn">Rechte Spalte</string>
47+
<string name="addListError">Füll alle Felder aus!</string>
4748
</resources>

app/src/main/res/values/strings.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,5 @@
4444
<string name="listName">List Name</string>
4545
<string name="leftColumn">Left Column</string>
4646
<string name="RightColumn">Right Column</string>
47+
<string name="addListError">Fill out all fields!</string>
4748
</resources>

0 commit comments

Comments
 (0)