Skip to content

Commit 666bcfa

Browse files
authored
Remove some xfails (#24)
* Remove xfail for test_chunk due to Cubed #546 fix * Remove xfail for test_unary_op (round) due to Xarray #9326 fix
1 parent 036e76b commit 666bcfa

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

cubed_xarray/tests/test_xarray.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,6 @@ def test_copy(self):
8686
self.assertLazyAndIdentical(self.eager_var, self.lazy_var.copy())
8787
self.assertLazyAndIdentical(self.eager_var, self.lazy_var.copy(deep=True))
8888

89-
@pytest.mark.xfail(
90-
reason="cubed rechunk handles chunks={} incorrectly, see https://github.com/cubed-dev/cubed/pull/546"
91-
)
9289
def test_chunk(self):
9390
for chunks, expected in [
9491
({}, ((2, 2), (2, 2, 2))),
@@ -151,7 +148,7 @@ def test_unary_op(self):
151148
v = self.lazy_var
152149
self.assertLazyAndIdentical(-u, -v)
153150
self.assertLazyAndIdentical(abs(u), abs(v))
154-
# self.assertLazyAndIdentical(u.round(), v.round()) # TODO: fails, see https://github.com/pydata/xarray/pull/9326
151+
self.assertLazyAndIdentical(u.round(), v.round())
155152

156153
def test_binary_op(self):
157154
u = self.eager_var
@@ -292,9 +289,6 @@ def setUp(self):
292289
self.data, coords={"x": range(4)}, dims=("x", "y"), name="foo"
293290
)
294291

295-
@pytest.mark.xfail(
296-
reason="cubed rechunk handles chunks={} incorrectly, see https://github.com/cubed-dev/cubed/pull/546"
297-
)
298292
def test_chunk(self) -> None:
299293
for chunks, expected in [
300294
({}, ((2, 2), (2, 2, 2))),

0 commit comments

Comments
 (0)