Skip to content

Commit 46f83db

Browse files
authored
Merge pull request #13 from cubed-dev/fix-typo-and-default-value
Fix `aggegrate_func` typo and default value for `drop_axis`
2 parents 7efd291 + 87f91e2 commit 46f83db

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

cubed_xarray/cubedmanager.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ def reduction(
8686
arr,
8787
func=func,
8888
combine_func=combine_func,
89-
aggegrate_func=aggregate_func, # TODO fix the typo in argument name in cubed
89+
aggregate_func=aggregate_func,
9090
axis=axis,
9191
dtype=dtype,
9292
keepdims=keepdims,
@@ -104,11 +104,6 @@ def map_blocks(
104104
):
105105
from cubed.core.ops import map_blocks
106106

107-
if drop_axis is None:
108-
# TODO should fix this upstream in cubed to match dask
109-
# see https://github.com/pydata/xarray/pull/7019#discussion_r1196729489
110-
drop_axis = []
111-
112107
return map_blocks(
113108
func,
114109
*args,

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ requires-python = ">=3.9"
2323
dependencies = [
2424
"numpy >= 1.17",
2525
"xarray >= 2024.02.0",
26-
"cubed >= 0.6.3",
26+
"cubed >= 0.14.2",
2727
]
2828

2929
[project.urls]

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
cubed>=0.6.0
1+
cubed>=0.14.2
22
numpy>=1.17.1
33
xarray>=2024.02.0

0 commit comments

Comments
 (0)