From 894901e2723a424de5f65abd03f27d2e6a19e66a Mon Sep 17 00:00:00 2001 From: Konstantin Burkalev Date: Fri, 6 Jun 2025 13:03:23 +0300 Subject: [PATCH] fix(cubesql): Propagate errors from SqlAuthService to the user --- packages/cubejs-api-gateway/src/sql-server.ts | 27 +++++++++++++------ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/packages/cubejs-api-gateway/src/sql-server.ts b/packages/cubejs-api-gateway/src/sql-server.ts index d09cf7437d5c9..cd3a6eeff0d05 100644 --- a/packages/cubejs-api-gateway/src/sql-server.ts +++ b/packages/cubejs-api-gateway/src/sql-server.ts @@ -128,14 +128,25 @@ export class SQLServer { }; }, checkSqlAuth: async ({ request, user, password }) => { - const { password: returnedPassword, superuser, securityContext, skipPasswordCheck } = await checkSqlAuth(request, user, password); - - return { - password: returnedPassword, - superuser: superuser || false, - securityContext, - skipPasswordCheck, - }; + try { + const { password: returnedPassword, superuser, securityContext, skipPasswordCheck } = await checkSqlAuth(request, user, password); + + return { + password: returnedPassword, + superuser: superuser || false, + securityContext, + skipPasswordCheck, + }; + } catch (e) { + this.apiGateway.log({ + type: 'Auth Error', + protocol: (request as any).protocol, + method: (request as any).method, + apiType: 'sql', + error: (e as Error).stack || (e as Error).toString(), + }); + throw e; + } }, meta: async ({ request, session, onlyCompilerId }) => { const context = await this.apiGateway.contextByReq( request, session.securityContext, request.id);