Skip to content

Commit ec5af7c

Browse files
committed
Revert "Temporary marked folder members as strings"
This reverts commit f7101f3.
1 parent 75a31fe commit ec5af7c

File tree

2 files changed

+14
-18
lines changed

2 files changed

+14
-18
lines changed

packages/cubejs-playground/src/QueryBuilderV2/components/SidePanelCubeItem.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -147,9 +147,7 @@ export function SidePanelCubeItem(props: CubeListItemProps) {
147147
const [openHierarchies, setOpenHierarchies] = useState<string[]>([]);
148148

149149
const folderMembers = folders.reduce((acc, folder) => {
150-
// FIXME: Temporary marked folder members as strings
151-
// It should be aware of recursive folders structure
152-
return acc.concat(folder.members as string[]);
150+
return acc.concat(folder.members);
153151
}, [] as string[]);
154152
const hierarchyMembers = hierarchies.reduce((acc, hierarchy) => {
155153
return acc.concat(hierarchy.levels);

packages/cubejs-playground/src/QueryBuilderV2/hooks/query-builder.ts

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1286,32 +1286,30 @@ export function useQueryBuilder(props: UseQueryBuilderProps) {
12861286

12871287
const folderStats = stats.folders[folderName];
12881288

1289-
// FIXME: Temporary marked folder members as strings
1290-
// It should be aware of recursive folders structure
12911289
folder.members.forEach((memberName) => {
1292-
if (stats.dimensions.includes(memberName as string)) {
1293-
if (!folderStats.dimensions.includes(memberName as string)) {
1294-
folderStats.dimensions.push(memberName as string);
1290+
if (stats.dimensions.includes(memberName)) {
1291+
if (!folderStats.dimensions.includes(memberName)) {
1292+
folderStats.dimensions.push(memberName);
12951293
}
1296-
} else if (stats.measures.includes(memberName as string)) {
1297-
if (!folderStats.measures.includes(memberName as string)) {
1298-
folderStats.measures.push(memberName as string);
1294+
} else if (stats.measures.includes(memberName)) {
1295+
if (!folderStats.measures.includes(memberName)) {
1296+
folderStats.measures.push(memberName);
12991297
}
1300-
} else if (stats.segments.includes(memberName as string)) {
1301-
if (!folderStats.segments.includes(memberName as string)) {
1302-
folderStats.segments.push(memberName as string);
1298+
} else if (stats.segments.includes(memberName)) {
1299+
if (!folderStats.segments.includes(memberName)) {
1300+
folderStats.segments.push(memberName);
13031301
}
1304-
} else if (stats.hierarchies[memberName as string]) {
1302+
} else if (stats.hierarchies[memberName]) {
13051303
// add all selected dimensions from the hierarchy
1306-
stats.hierarchies[memberName as string].forEach((levelMemberName) => {
1304+
stats.hierarchies[memberName].forEach((levelMemberName) => {
13071305
if (!folderStats.dimensions.includes(levelMemberName)) {
13081306
folderStats.dimensions.push(levelMemberName);
13091307
}
13101308
});
13111309
}
13121310

1313-
if (grouping.includes(memberName as string)) {
1314-
folderStats.grouping.push(memberName as string);
1311+
if (grouping.includes(memberName)) {
1312+
folderStats.grouping.push(memberName);
13151313
}
13161314
});
13171315
});

0 commit comments

Comments
 (0)