fix(schema-compiler): Fix pre-aggregation for time dimension matching (#9669)

Author: KSDaemon

packages/cubejs-schema-compiler/src/adapter/BaseQuery.js

@@ -2403,7 +2403,7 @@ export class BaseQuery {
    */
   collectCubeNames() {
     return this.collectFromMembers(
-      [],
+      false,
       this.collectCubeNamesFor.bind(this),
       'collectCubeNamesFor'
     );

packages/cubejs-schema-compiler/test/unit/pre-aggregations.test.ts

@@ -450,6 +450,62 @@ describe('pre-aggregations', () => {
     expect(preAggregationsDescription[0].invalidateKeyQueries[0][1]).toEqual(['__FROM_PARTITION_RANGE', '__TO_PARTITION_RANGE']);
   });
 
+  it('pre-aggregation match for only td query', async () => {
+    const { compiler, cubeEvaluator, joinGraph } = prepareYamlCompiler(
+      createSchemaYaml({
+        cubes: [
+          {
+            name: 'orders',
+            sql_table: 'orders',
+            measures: [{
+              name: 'count',
+              type: 'count',
+            }],
+            dimensions: [
+              {
+                name: 'created_at',
+                sql: 'created_at',
+                type: 'time',
+              },
+              {
+                name: 'status',
+                sql: 'status',
+                type: 'string',
+              }
+            ],
+            preAggregations: [
+              {
+                name: 'simple',
+                measures: ['count'],
+                dimensions: ['status'],
+                timeDimension: 'CUBE.created_at',
+                granularity: 'day',
+              },
+            ]
+          }
+        ]
+      })
+    );
+
+    await compiler.compile();
+
+    // It's important to provide a queryFactory, as it triggers flow
+    // with paramAllocator reset in BaseQuery->newSubQueryForCube()
+    const queryFactory = new QueryFactory({ orders: PostgresQuery });
+
+    const query = new PostgresQuery({ joinGraph, cubeEvaluator, compiler }, {
+      timeDimensions: [{
+        dimension: 'orders.created_at',
+        granularity: 'day',
+      }],
+      queryFactory
+    });
+
+    const preAggregationsDescription: any = query.preAggregations?.preAggregationsDescription();
+    expect(preAggregationsDescription.length).toEqual(1);
+    expect(preAggregationsDescription[0].preAggregationId).toEqual('orders.simple');
+  });
+
   describe('rollup with multiplied measure', () => {
     let compiler;
     let cubeEvaluator;