Merge pull request #59 from cs130-w21/coverage

Improved test coverage

Author: elrodrigues

tests/conftest.py

@@ -23,6 +23,13 @@ def app():
 	os.close(db_fd)
 	os.unlink(db_path)
 
+@pytest.fixture
+def app_no_test():
+	app = create_app(None)
+	# Warning: do not use this fixture for testing beyond
+	# initialization. If you need to, initialize the 
+	# DB here. (NOT RECOMMENDED)
+	yield app
 
 @pytest.fixture
 def client(app):

tests/data.sql

@@ -1,4 +1,6 @@
 INSERT INTO profiles (uid, profile)
 VALUES
     ('DEEPFKNVAL', '{"EXPEXT": 85, "IMPDIS": 84, "ATTDEP": 50, "SENTIM": 0, "INVEST": 1, "HOBBIE": "diamondhands"}'),
-    ('A1B2C3D4E5', '{"EXPEXT": 42, "IMPDIS": 42, "ATTDEP": 42, "SENTIM": 42, "INVEST": 3, "HOBBIE": "life"}');
+    ('A1B2C3D4E5', '{"EXPEXT": 42, "IMPDIS": 42, "ATTDEP": 42, "SENTIM": 42, "INVEST": 3, "HOBBIE": "life"}'),
+    ('AAAAAAAAAA', '{"EXPEXT": 42, "IMPDIS": 42, "ATTDEP": 42, "SENTIM": 42, "INVEST": 3, "HOBBIE": "life"}'),
+    ('BBBBBBBBBB', '{"EXPEXT": 42, "IMPDIS": 42, "ATTDEP": 42, "SENTIM": 42, "HOBBIE": "life"}');

tests/test_compare.py

@@ -8,8 +8,6 @@ def test_get_compare(client):
     get_response = client.get('compare/<placeholder>', follow_redirects=True)
     assert b"Compare Portfolios" in get_response.data
 
-# PLACEHOLDER TEST
-# TODO: Implement this in Sprint 3
 def test_post_compare(client):
     # Enter same ID
     post_response = client.post('compare/<placeholder>', data=dict(
@@ -26,12 +24,43 @@ def test_post_compare(client):
     ), follow_redirects=True)
     assert b"Compare Portfolios" in post_response.data
     assert b"Invalid ID" in post_response.data
+
+    post_response = client.post('compare/<placholder>', data=dict(
+            person1='ZZZZZZZZZZ',
+            person2=TEST_ID1
+    ), follow_redirects=True)
+    assert b"Compare Portfolios" in post_response.data
+    assert b"Invalid ID" in post_response.data
     # Enter two IDs
 
     # no portfolio in session, so should redirect to index
-    # TODO: implement this when Compare is implemented
     post_response = client.post('compare/<placeholder>', data=dict(
             person1=TEST_ID1,
             person2=TEST_ID2
     ), follow_redirects=True)
     assert b"Your Compatibility is" in post_response.data
+
+def test_post_compare2(client):
+    # check for incomplete 
+    post_response = client.post('compare/<placeholder>', data=dict(
+        person1='BBBBBBBBBB',
+        person2=TEST_ID2
+    ), follow_redirects=True)
+    assert b"Your Compatibility is" in post_response.data
+
+    post_response = client.post('compare/<placeholder>', data=dict(
+        person1=TEST_ID1,
+        person2='BBBBBBBBBB'
+    ), follow_redirects=True)
+    assert b"Your Compatibility is" in post_response.data
+    # same hobbie
+    post_response = client.post('compare/<placeholder>', data=dict(
+        person1=TEST_ID2,
+        person2='AAAAAAAAAA'
+    ), follow_redirects=True)
+    assert b"Your Compatibility is" in post_response.data
+
+def test_compare_with_code(client):
+    get_response = client.get('compare/AAAAAAAAAA', follow_redirects=True)
+    assert b"Compare Portfolios" in get_response.data
+    assert b"AAAAAAAAAA" in get_response.data

tests/test_index.py

@@ -72,3 +72,16 @@ def test_index(client):
     ), follow_redirects=True)
     assert b"Number of Shares must be a positive integer" in post_response.data
     assert b"Get My Results" not in get_response.data
+
+def test_about_remove(client):
+    get_response = client.get('about')
+    assert b"Website created by..." in get_response.data
+
+    get_response = client.get('remove/ZZZZ',
+        follow_redirects = True)
+    assert b"Welcome to StockMeetsBagel" in get_response.data
+    assert b"Get My Results" not in get_response.data
+    
+def test_app_no_config(client, app_no_test):
+    get_response = client.get('about')
+    assert b"Website created by..." in get_response.data

tests/test_results.py

@@ -1,6 +1,7 @@
 import pytest
 
 from flaskr.db import get_db
+import sqlite3
 
 TEST_STOCK = 'AMZN'
 TEST_SHARES = '1'
@@ -45,3 +46,95 @@ def test_stock_in_session(client, app):
     get_response = client.get('results', follow_redirects=True)
     assert b"Your profile has been generated." in get_response.data
     assert b"Compare Our Results" in get_response.data
+
+def test_total_value(client, monkeypatch):
+    def fake_financials(_self, symbol, typ):
+        return dict(
+            metric={
+                '52WeekHigh': '1',
+                '52WeekLow': '1',
+                'bookValuePerShareAnnual': '1',
+                'marketCapitalization': '1'
+            }
+            )
+    monkeypatch.setattr('finnhub.Client.company_basic_financials', fake_financials)
+    client.post('/', data=dict(
+            stock='XELA',
+            volume='1'
+    ), follow_redirects=True)
+    get_response = client.get('results', follow_redirects=True)
+    assert b"Your profile has been generated." in get_response.data
+    assert b"Compare Our Results" in get_response.data
+
+    client.post('/', data=dict(
+            stock='XELA',
+            volume='5000'
+    ), follow_redirects=True)
+    get_response = client.get('results', follow_redirects=True)
+    assert b"Your profile has been generated." in get_response.data
+    assert b"Compare Our Results" in get_response.data
+
+    client.post('/', data=dict(
+            stock='XELA',
+            volume='40000'
+    ), follow_redirects=True)
+    get_response = client.get('results', follow_redirects=True)
+    assert b"Your profile has been generated." in get_response.data
+    assert b"Compare Our Results" in get_response.data
+
+    client.post('/', data=dict(
+            stock='XELA',
+            volume='100000'
+    ), follow_redirects=True)
+    get_response = client.get('results', follow_redirects=True)
+    assert b"Your profile has been generated." in get_response.data
+    assert b"Compare Our Results" in get_response.data
+
+    client.post('/', data=dict(
+            stock='XELA',
+            volume='250000'
+    ), follow_redirects=True)
+    get_response = client.get('results', follow_redirects=True)
+    assert b"Your profile has been generated." in get_response.data
+    assert b"Compare Our Results" in get_response.data
+
+    client.post('/', data=dict(
+            stock='XELA',
+            volume='650000'
+    ), follow_redirects=True)
+    get_response = client.get('results', follow_redirects=True)
+    assert b"Your profile has been generated." in get_response.data
+    assert b"Compare Our Results" in get_response.data
+
+def test_sectors(client, monkeypatch):
+    def fake_profile2(_self, **params):
+        return dict(finnhubIndustry='gamer')
+    monkeypatch.setattr('finnhub.Client.company_profile2', fake_profile2)
+
+    client.post('/', data=dict(
+            stock='XELA',
+            volume='10'
+    ), follow_redirects=True)
+    client.post('/', data=dict(
+            stock='MSFT',
+            volume='1'
+    ), follow_redirects=True)
+    
+    get_response = client.get('results', follow_redirects=True)
+    assert b"Your profile has been generated." in get_response.data
+    assert b"Compare Our Results" in get_response.data
+
+def test_generate_uid(client, app, monkeypatch):
+    def fake_secrets_choice(sequence):
+        return 'A'
+
+    monkeypatch.setattr('secrets.choice', fake_secrets_choice)
+
+    client.post('/', data=dict(
+            stock=TEST_STOCK,
+            volume=TEST_SHARES
+    ), follow_redirects=True)
+
+    with pytest.raises(sqlite3.IntegrityError) as e:
+        get_response = client.get('results', follow_redirects=True)
+    assert 'UNIQUE' in str(e.value)