Skip to content

Commit f32649f

Browse files
committed
Add missing scope and claim config values
1 parent a9cf3d0 commit f32649f

File tree

3 files changed

+24
-5
lines changed

3 files changed

+24
-5
lines changed

client/extensions.js

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -221,12 +221,17 @@ define([
221221
const pkInput = blocks.textarea();
222222
const pkLabel = blocks.labelledInput(MyMessages.provider_saml_private, pkInput);
223223

224+
// User name
225+
const nameInput = blocks.input();
226+
const nameLabel = blocks.labelledInput(MyMessages.provider_saml_name, nameInput);
227+
224228
if (isEdit) {
225229
urlInput.value = isEdit.url;
226230
issuerInput.value = isEdit.issuer || '';
227231
idpcInput.value = isEdit.cert || '';
228232
spcInput.value = isEdit.signingCert || '';
229233
pkInput.value = isEdit.privateKey || '';
234+
nameInput.value = isEdit.username_attr || '';
230235
}
231236

232237
getValues = () => {
@@ -237,7 +242,8 @@ define([
237242
issuer: issuerInput.value,
238243
cert: idpcInput.value,
239244
signingCert: spcInput.value,
240-
privateKey: pkInput.value
245+
privateKey: pkInput.value,
246+
username_attr: nameInput.value
241247
};
242248
};
243249

@@ -264,7 +270,7 @@ define([
264270
const idAlgLabel = blocks.labelledInput(MyMessages.provider_oidc_idalg, idAlgInput);
265271

266272
// User Info alg
267-
const userAlgInput = blocks.input({placeholder:'PS256'});
273+
const userAlgInput = blocks.input();
268274
const userAlgLabel = blocks.labelledInput(MyMessages.provider_oidc_useralg, userAlgInput);
269275

270276
// PKCE
@@ -273,6 +279,12 @@ define([
273279
// Nonce
274280
const nonce = blocks.checkbox(`sso-nonce-${uid}`, MyMessages.provider_oidc_nonce, true);
275281

282+
// User name
283+
const userScopeInput = blocks.input({placeholder:'profile'});
284+
const userScopeLabel = blocks.labelledInput(MyMessages.provider_oidc_userscope, userScopeInput);
285+
const userClaimInput = blocks.input({placeholder:'name'});
286+
const userClaimLabel = blocks.labelledInput(MyMessages.provider_oidc_userclaim, userClaimInput);
287+
276288
if (isEdit) {
277289
urlInput.value = isEdit.url || '';
278290
cidInput.value = isEdit.client_id || '';
@@ -281,6 +293,8 @@ define([
281293
userAlgInput.value = isEdit.userinfo_token_alg || isEdit.jwt_alg || '';
282294
$(pkce).find('input').prop('checked', isEdit.use_pkce !== false);
283295
$(nonce).find('input').prop('checked', isEdit.use_nonce !== false);
296+
userScopeInput.value = isEdit.username_scope || '';
297+
userClaimInput.value = isEdit.username_claim || '';
284298
}
285299

286300
getValues = () => {
@@ -293,10 +307,12 @@ define([
293307
id_token_alg: idAlgInput.value || isEdit.jwt_alg || undefined,
294308
userinfo_token_alg: userAlgInput.value || isEdit.jwt_alg || undefined,
295309
use_nonce: $(nonce).find('input').is(':checked'),
296-
use_pkce: $(pkce).find('input').is(':checked')
310+
use_pkce: $(pkce).find('input').is(':checked'),
311+
username_scope: userScopeInput.value,
312+
username_claim: userClaimInput.value,
297313
};
298314
};
299-
$(form).append([urlLabel, cidLabel, secretLabel, idAlgLabel, userAlgLabel, pkce, nonce]);
315+
$(form).append([urlLabel, cidLabel, secretLabel, idAlgLabel, userAlgLabel, pkce, nonce, userScopeLabel, userClaimLabel]);
300316
});
301317

302318
if (isEdit) {

client/translations/messages.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,12 @@
2424
"provider_oidc_useralg":"User Info response algorithm",
2525
"provider_oidc_pkce":"Use PKCE code challenge",
2626
"provider_oidc_nonce":"Use nonce",
27+
"provider_oidc_userscope":"Username Scope",
28+
"provider_oidc_userclaim":"Username Claim",
2729
"provider_saml_issuer":"Issuer ID",
2830
"provider_saml_idpcert":"IdP certificate",
2931
"provider_saml_providercert":"Service provider certificate",
3032
"provider_saml_private":"Private signing key",
33+
"provider_saml_name":"Username attribute",
3134
"provider_remove_confirm": "Remove this identity provider?"
3235
}

protocols/oidc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ module.exports = (SSOUtils) => {
1515
Env.Log.verbose('DISCOVERED_OPENID_ISSUER', {name:cfg.name});
1616

1717
let id_alg = cfg.id_token_alg || cfg.jwt_alg || 'PS256';
18-
let user_alg = cfg.userinfo_token_alg || cfg.jwt_alg || 'PS256';
18+
let user_alg = cfg.userinfo_token_alg || cfg.jwt_alg || '';
1919

2020
// ID token alg supported
2121
let its = issuer.id_token_signing_alg_values_supported;

0 commit comments

Comments
 (0)