style(phpcs): Upgrade to PHP CS Fixer v3

Author: julienloizelet

.php_cs renamed to .php-cs-fixer.php

@@ -4,7 +4,8 @@
     exit(0);
 }
 
-return PhpCsFixer\Config::create()
+$config = new PhpCsFixer\Config;
+return $config
     ->setRules([
         '@Symfony' => true,
         '@Symfony:risky' => true,

docs/ddev.md

@@ -216,4 +216,23 @@ Now, if you run the php script against the `1.2.3.4` IP:
 ddev exec php check-ip.php 1.2.3.4 <BOUNCER_KEY>
 ```
 
-LAPI will advise you to ban this IP as it's within the 1.2.3.4/30 range.
+LAPI will advise you to ban this IP as it's within the 1.2.3.4/30 range.
+
+
+### Coding standards
+
+#### PHPCS
+
+We are using the [PHP Coding Standards Fixer](https://cs.symfony.com/)
+
+With ddev, you can do the following:
+
+```command
+ddev composer update --working-dir=./my-own-modules/crowdsec-php-lib/tools/php-cs-fixer
+```
+And then:
+
+```
+ddev exec PHP_CS_FIXER_IGNORE_ENV=1 ./my-own-modules/crowdsec-php-lib/tools/php-cs-fixer/vendor/bin/php-cs-fixer fix ./my-own-modules/crowdsec-php-lib
+
+```

tests/TestHelpers.php

@@ -12,21 +12,21 @@
 
 class TestHelpers
 {
-    const BAD_IP = '1.2.3.4';
-    const CLEAN_IP = '2.3.4.5';
-    const NEWLY_BAD_IP = '3.4.5.6';
-    const IP_RANGE = '24';
-    const LARGE_IPV4_RANGE = '23';
-    const BAD_IPV6 = '2001:0db8:85a3:0000:0000:8a2e:0370:7334';
-    const IPV6_RANGE = '64';
+    public const BAD_IP = '1.2.3.4';
+    public const CLEAN_IP = '2.3.4.5';
+    public const NEWLY_BAD_IP = '3.4.5.6';
+    public const IP_RANGE = '24';
+    public const LARGE_IPV4_RANGE = '23';
+    public const BAD_IPV6 = '2001:0db8:85a3:0000:0000:8a2e:0370:7334';
+    public const IPV6_RANGE = '64';
 
-    const FS_CACHE_ADAPTER_DIR = __DIR__.'/../var/fs.cache';
-    const PHP_FILES_CACHE_ADAPTER_DIR = __DIR__.'/../var/phpFiles.cache';
+    public const FS_CACHE_ADAPTER_DIR = __DIR__.'/../var/fs.cache';
+    public const PHP_FILES_CACHE_ADAPTER_DIR = __DIR__.'/../var/phpFiles.cache';
 
-    const WATCHER_LOGIN = 'PhpUnitTestMachine';
-    const WATCHER_PASSWORD = 'PhpUnitTestMachinePassword';
+    public const WATCHER_LOGIN = 'PhpUnitTestMachine';
+    public const WATCHER_PASSWORD = 'PhpUnitTestMachinePassword';
 
-    const LOG_LEVEL = Logger::WARNING; // set to Logger::DEBUG to get high verbosity
+    public const LOG_LEVEL = Logger::WARNING; // set to Logger::DEBUG to get high verbosity
 
     public static function createLogger(): Logger
     {

tests/WatcherClient.php

@@ -8,8 +8,8 @@
 
 class WatcherClient
 {
-    const WATCHER_LOGIN = 'PhpUnitTestMachine';
-    const WATCHER_PASSWORD = 'PhpUnitTestMachinePassword';
+    public const WATCHER_LOGIN = 'PhpUnitTestMachine';
+    public const WATCHER_PASSWORD = 'PhpUnitTestMachinePassword';
 
     /** @var LoggerInterface */
     private $logger;

tools/php-cs-fixer/composer.json

@@ -1,5 +1,5 @@
 {
     "require": {
-        "friendsofphp/php-cs-fixer": "^2.17"
+        "friendsofphp/php-cs-fixer": "^3.5"
     }
 }