strip '=' signs from encoded api keys (#2472)

mmetc · buixor · web-flow · commit ac01faf48382 · 2023-09-19T14:00:23.000+02:00
Co-authored-by: Thibault "bui" Koechlin &lt;thibault@crowdsec.net&gt;
diff --git a/pkg/apiserver/middlewares/v1/api_key.go b/pkg/apiserver/middlewares/v1/api_key.go
@@ -33,7 +33,9 @@ func GenerateAPIKey(n int) (string, error) {
 	if _, err := rand.Read(bytes); err != nil {
 		return "", err
 	}
-	return base64.StdEncoding.EncodeToString(bytes), nil
+	encoded := base64.StdEncoding.EncodeToString(bytes)
+	// the '=' can cause issues on some bouncers
+	return strings.TrimRight(encoded, "="), nil
 }
 
 func NewAPIKey(dbClient *database.Client) *APIKey {

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,9 @@ func GenerateAPIKey(n int) (string, error) {`
`33`	`33`	`if _, err := rand.Read(bytes); err != nil {`
`34`	`34`	`return "", err`
`35`	`35`	`}`
`36`		`- return base64.StdEncoding.EncodeToString(bytes), nil`
	`36`	`+ encoded := base64.StdEncoding.EncodeToString(bytes)`
	`37`	`+ // the '=' can cause issues on some bouncers`
	`38`	`+ return strings.TrimRight(encoded, "="), nil`
`37`	`39`	`}`
`38`	`40`
`39`	`41`	`func NewAPIKey(dbClient database.Client) APIKey {`