fix: ensure proper migration order for database schema

test

Author: kieranklaassen

lib/generators/ruby_llm/install/templates/create_messages_migration.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+# This migration must be run AFTER create_chats and create_tool_calls migrations
+# to ensure proper foreign key references
 class CreateMessages < ActiveRecord::Migration<%= migration_version %>
   def change
     create_table :messages do |t|
@@ -9,7 +11,7 @@ def change
       t.string :model_id
       t.integer :input_tokens
       t.integer :output_tokens
-      t.references :tool_call
+      t.references :tool_call, foreign_key: true
       t.timestamps
     end
   end

lib/generators/ruby_llm/install/templates/create_tool_calls_migration.rb

@@ -4,7 +4,8 @@
 class CreateToolCalls < ActiveRecord::Migration<%= migration_version %>
   def change
     create_table :tool_calls do |t|
-      t.references :message, null: false, foreign_key: true
+      # No reference to message to avoid circular references
+      # Messages will reference tool_calls, not the other way around
       t.string :tool_call_id, null: false
       t.string :name, null: false
 

lib/generators/ruby_llm/install_generator.rb

@@ -27,9 +27,23 @@ def postgresql?
     end
 
     def create_migration_files
+      # Create migrations in the correct order with sequential timestamps
+      # to ensure proper foreign key references:
+      # 1. First create chats (no dependencies)
+      # 2. Then create tool_calls (will be referenced by messages)
+      # 3. Finally create messages (depends on both chats and tool_calls)
+      
+      # Use a fixed timestamp for testing and to ensure they're sequential
+      @migration_number = Time.now.utc.strftime("%Y%m%d%H%M%S")
       migration_template "create_chats_migration.rb", "db/migrate/create_chats.rb"
-      migration_template "create_messages_migration.rb", "db/migrate/create_messages.rb"
+      
+      # Increment timestamp for the next migration
+      @migration_number = (@migration_number.to_i + 1).to_s
       migration_template "create_tool_calls_migration.rb", "db/migrate/create_tool_calls.rb"
+      
+      # Increment timestamp again for the final migration
+      @migration_number = (@migration_number.to_i + 2).to_s
+      migration_template "create_messages_migration.rb", "db/migrate/create_messages.rb"
     end
 
     def create_model_files

spec/lib/generators/ruby_llm/template_files_spec.rb

@@ -30,10 +30,11 @@
       expect(message_migration).to include("t.references :chat")
       expect(message_migration).to include("t.string :role")
       expect(message_migration).to include("t.text :content")
+      expect(message_migration).to include("t.references :tool_call")
 
       tool_call_migration = File.read(File.join(template_dir, "create_tool_calls_migration.rb"))
       expect(tool_call_migration).to include("create_table :tool_calls")
-      expect(tool_call_migration).to include("t.references :message")
+      expect(tool_call_migration).to include("# No reference to message to avoid circular references")
       expect(tool_call_migration).to include("t.string :tool_call_id")
       expect(tool_call_migration).to include("t.string :name")
 
@@ -97,6 +98,31 @@
       expect(generator_content).to include("def create_model_files")
       expect(generator_content).to include("def create_initializer")
     end
+    
+    it "creates migrations in the correct order" do
+      generator_file = "/Users/kieranklaassen/rails/ruby_llm/lib/generators/ruby_llm/install_generator.rb"
+      generator_content = File.read(generator_file)
+      
+      # Check for correct order in migration creation
+      # 1. First chats table (no dependencies)
+      # 2. Then tool_calls table (will be referenced by messages)
+      # 3. Finally messages table (depends on both chats and tool_calls)
+      
+      # Simply check the order of template calls
+      # Chats should come before tool_calls, which should come before messages
+      chats_position = generator_content.index('create_chats.rb')
+      tool_calls_position = generator_content.index('create_tool_calls.rb') 
+      messages_position = generator_content.index('create_messages.rb')
+      
+      # Verify order: chats -> tool_calls -> messages
+      expect(chats_position).to be < tool_calls_position
+      expect(tool_calls_position).to be < messages_position
+      
+      # Also test that the method enforces sequential timestamps
+      expect(generator_content).to include("@migration_number = Time.now.utc.strftime")
+      expect(generator_content).to include("@migration_number = (@migration_number.to_i + 1).to_s")
+      expect(generator_content).to include("@migration_number = (@migration_number.to_i + 2).to_s")
+    end
   end
 
   describe "database adapter detection" do